plans for 0.12

plans for 0.12

[David Bremner]

[-- Attachment #1: Type: text/plain, Size: 1176 bytes --]


I would like to start a freeze (i.e. merge master to release) for 0.12
within the next week, say March 1 for an easy to remember date.

If you have suggestions for things that "should really go in", feel free
to follow up. The main point here is bug fixes, or features which are
there in a kindof half baked way.

Bug fix wise, I know about 
  
  id:"1330068983-4483-1-git-send-email-sojkam1@fel.cvut.cz"

This could use some review.

It has also been some chatter that either (the next iteration of)

   id:"1329296619-7463-1-git-send-email-markwalters1009@gmail.com" 

Should go in, or we should revert amdragon's exclude stuff. 

I don't have strong feelings either way, except it is somewhat late in
the day for a large(ish) and complicated series.

There are several other patch series that look ready from a review point
of view, but I'd rather have them pushed earlier in the release cycle
(or at least I don't see a hurry). For example 

   id:"1329490088-8323-2-git-send-email-dmitry.kurochkin@gmail.com"
   id:"1329697590-7404-1-git-send-email-amdragon@mit.edu"

My (tentative) plan is to push those once I have branched for release.

[-- Attachment #2: Type: application/pgp-signature, Size: 315 bytes --]

Re: plans for 0.12

[Mark Walters]

On Sat, 25 Feb 2012 10:27:02 -0400, David Bremner <david@tethera.net> wrote:
> 
> I would like to start a freeze (i.e. merge master to release) for 0.12
> within the next week, say March 1 for an easy to remember date.
> 
> If you have suggestions for things that "should really go in", feel free
> to follow up. The main point here is bug fixes, or features which are
> there in a kindof half baked way.
> 
> Bug fix wise, I know about 
>   
>   id:"1330068983-4483-1-git-send-email-sojkam1@fel.cvut.cz"
> 
> This could use some review.
> 
> It has also been some chatter that either (the next iteration of)
> 
>    id:"1329296619-7463-1-git-send-email-markwalters1009@gmail.com" 
> 
> Should go in, or we should revert amdragon's exclude stuff. 
> 
> I don't have strong feelings either way, except it is somewhat late in
> the day for a large(ish) and complicated series.

I agree it is a largish patch set: I think I would err against including
it for 0.12 as it has not had a lot of testing (I think only by me). It
would also allow people to work out what they wanted emacs to do with
the exclude flag. (The notmuch-show.el patch 12/13 needs simple rebasing
which I have done but not posted yet.)

A temporary revert might be reasonable: alternatively we could just turn
off the automatic addition of the exclude tags (deleted and spam) to the
config file in notmuch-config so only users who ask for it get it on
this release.

If it is not reverted then I think patches 1-3 of the latest series
id:"1330157204-26094-1-git-send-email-markwalters1009@gmail.com"
might be worth including. They just add the --no-exclude option to
notmuch-count and notmuch-search and are simple (it's one "code" patch,
one "man" patch and some tests).

I guess my favoured option would just be to disable the automatic
addition of exclude tags (ideally with patches 1-3 above, but that is
not important).

Best wishes

Mark

> There are several other patch series that look ready from a review point
> of view, but I'd rather have them pushed earlier in the release cycle
> (or at least I don't see a hurry). For example 
> 
>    id:"1329490088-8323-2-git-send-email-dmitry.kurochkin@gmail.com"
>    id:"1329697590-7404-1-git-send-email-amdragon@mit.edu"
> 
> My (tentative) plan is to push those once I have branched for release.
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: plans for 0.12

[Jameson Graef Rollins]

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

On Sat, 25 Feb 2012 10:27:02 -0400, David Bremner <david@tethera.net> wrote:
> It has also been some chatter that either (the next iteration of)
> 
>    id:"1329296619-7463-1-git-send-email-markwalters1009@gmail.com" 
> 
> Should go in, or we should revert amdragon's exclude stuff. 
> 
> I don't have strong feelings either way, except it is somewhat late in
> the day for a large(ish) and complicated series.

If we go the revert route please only revert from the 0.12 release
branch.  I am using and enjoying this feature now, and would not like to
see further development of it stalled.  Thanks so much to those of you
who have been pushing on it.

jamie.

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: plans for 0.12

[Pieter Praet]

On Sat, 25 Feb 2012 10:27:02 -0400, David Bremner <david@tethera.net> wrote:
> 
> I would like to start a freeze (i.e. merge master to release) for 0.12
> within the next week, say March 1 for an easy to remember date.
> 
> If you have suggestions for things that "should really go in", feel free
> to follow up. The main point here is bug fixes, or features which are
> there in a kindof half baked way.
>

Some of the features added/refactored post-0.11.1 don't have any
test coverage yet.  Should they, before wrapping up 0.12 ?
(not a rhetorical question, I'm genuinely asking for opinions)


Anyways, I've taken the liberty of tagging the following patches '0.12':

- test: emacs: toggle processing of cryptographic MIME parts in `notmuch-show'
  - id:"1329684990-12504-2-git-send-email-pieter@praet.org"
- test: emacs: toggle eliding of non-matching messages in `notmuch-show'
  - id:"1329684990-12504-3-git-send-email-pieter@praet.org"
- test: emacs: toggle thread content indentation in `notmuch-show'
  - id:"1329684990-12504-4-git-send-email-pieter@praet.org"

- test: emacs: new tests "notmuch-show: {add,remove} multiple tags {to,from} single message"
  - id:"1330122640-18895-2-git-send-email-pieter@praet.org"
- test: emacs: new test "notmuch-show: change tags of all messages in current buffer"
  - id:"1330122640-18895-3-git-send-email-pieter@praet.org"

- test: emacs: new test "notmuch-search: change tags of all matching messages"
  - id:"1329936867-923-1-git-send-email-pieter@praet.org"

If applied in that order, the last one needs to be applied with the
`--3way' option, which results in an easily resolved merge conflict,
but if needed, I'll rebase it.


> Bug fix wise, I know about 
>   
>   id:"1330068983-4483-1-git-send-email-sojkam1@fel.cvut.cz"
> 
> This could use some review.
> 
> It has also been some chatter that either (the next iteration of)
> 
>    id:"1329296619-7463-1-git-send-email-markwalters1009@gmail.com" 
> 
> Should go in, or we should revert amdragon's exclude stuff. 
> 
> I don't have strong feelings either way, except it is somewhat late in
> the day for a large(ish) and complicated series.
> 
> There are several other patch series that look ready from a review point
> of view, but I'd rather have them pushed earlier in the release cycle
> (or at least I don't see a hurry). For example 
> 
>    id:"1329490088-8323-2-git-send-email-dmitry.kurochkin@gmail.com"
>    id:"1329697590-7404-1-git-send-email-amdragon@mit.edu"
> 
> My (tentative) plan is to push those once I have branched for release.
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch


Peace

-- 
Pieter

Re: plans for 0.12

[David Bremner]

On Thu, 01 Mar 2012 22:21:29 +0100, Pieter Praet <pieter@praet.org> wrote:
> 
> Some of the features added/refactored post-0.11.1 don't have any
> test coverage yet.  Should they, before wrapping up 0.12 ?
> (not a rhetorical question, I'm genuinely asking for opinions)
> 

Hi Pieter;

My initial answer is probably not. I see the tests as mainly useful
during development, for detecting regressions. I think most people doing
development will be working from git, rather than the distribution
tarballs we ship.   

On the other hand, adding tests is also not that risky, so if the
concensus is strongly in favour of integrating them pre 0.12, and
somebody wants to review them all, then I'm willing to consider it.

d

Re: plans for 0.12

[Pieter Praet]

On Thu, 01 Mar 2012 18:43:50 -0400, David Bremner <david@tethera.net> wrote:
> On Thu, 01 Mar 2012 22:21:29 +0100, Pieter Praet <pieter@praet.org> wrote:
> > 
> > Some of the features added/refactored post-0.11.1 don't have any
> > test coverage yet.  Should they, before wrapping up 0.12 ?
> > (not a rhetorical question, I'm genuinely asking for opinions)
> > 
> 
> Hi Pieter;
> 
> My initial answer is probably not. I see the tests as mainly useful
> during development, for detecting regressions. I think most people doing
> development will be working from git, rather than the distribution
> tarballs we ship.   
> 
> On the other hand, adding tests is also not that risky, so if the
> concensus is strongly in favour of integrating them pre 0.12, and
> somebody wants to review them all, then I'm willing to consider it.
>

Fair enough.

Just in case anyone considers them beneficial and/or is willing to
review (whether it be for inclusion in 0.12 or later), I've gotten
rid of the merge conflict by moving the last test to a new file
called `emacs-search' [1] (also see [2]).  Other than that, it
remains unchanged.

> d


Peace

-- 
Pieter

[1] id:"1331149792-17192-1-git-send-email-pieter@praet.org"
[2] id:"87aa47euao.fsf@praet.org"

Re: plans for 0.12

[David Bremner]

On Thu, 01 Mar 2012 22:21:29 +0100, Pieter Praet <pieter@praet.org> wrote:
> On Sat, 25 Feb 2012 10:27:02 -0400, David Bremner <david@tethera.net> wrote:
> > 
> > I would like to start a freeze (i.e. merge master to release) for 0.12
> > within the next week, say March 1 for an easy to remember date.
> > 

I have tagged and pushed 0.12~rc1; as usual there are no tarballs,
except in Debian experimental.

Barring explosions, I'd like to do the final release this weekend, so
please let me know if there are any NEWS updates.

d

[PATCH] NEWS: add entry for `notmuch-show-stash-mlarchive-link{, -and-go}'

[Pieter Praet]

---
 NEWS |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/NEWS b/NEWS
index 8fb2f24..a739914 100644
--- a/NEWS
+++ b/NEWS
@@ -80,6 +80,12 @@ Attachment buttons can be used to view or save attachments.
   button 1 saves the attachment but this is customisable (option
   Notmuch Show Part Button Default Action).
 
+New functions
+
+  `notmuch-show-stash-mlarchive-link{,-and-go}' allow stashing and
+  optionally visiting a URI to the current message at one of a number
+  of Mailing List Archives.
+
 Library changes
 ---------------
 
-- 
1.7.8.1

Re: [PATCH] NEWS: add entry for `notmuch-show-stash-mlarchive-link{, -and-go}'

[David Bremner]

On Thu,  1 Mar 2012 22:44:30 +0100, Pieter Praet <pieter@praet.org> wrote:
> ---
>  NEWS |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)

Pushed to release, I'll merge to master soon.

d