From: David Bremner <david@tethera.net>
To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] Make parsing of References and In-Reply-To header less error prone
Date: Sun, 13 Jul 2014 11:54:48 -0300 [thread overview]
Message-ID: <8761j1fgw7.fsf@maritornes.cs.unb.ca> (raw)
In-Reply-To: <1401113157-32454-3-git-send-email-sojkam1@fel.cvut.cz>
Michal Sojka <sojkam1@fel.cvut.cz> writes:
> According to RFC2822 References and In-Reply-To headers are supposed
> to contain one or more Message-IDs, however older RFC822 allowed
> almost any content. When both References and In-Reply-To headers ends
> with something else that a Message-ID (see e.g. [1]), the thread
> structure presented by notmuch is incorrect. The reason is that
> notmuch treats this case as if the email contained no "replyto"
> information (see _notmuch_database_link_message_to_parents).
>
> This patch changes the parse_references() function to return the last
> valid Message-ID encountered rather than NULL resulting from the last
> hunk of text not being the Message-ID.
This series looks OK to me. It does touch something pretty fundamental,
so I'd appreciate a second set of eyes on it.
d
next prev parent reply other threads:[~2014-07-13 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 14:05 [PATCH 0/2] Improve message threading Michal Sojka
2014-05-26 14:05 ` [PATCH 1/2] Add test for incorrect threading of messages Michal Sojka
2014-05-26 14:05 ` [PATCH 2/2] Make parsing of References and In-Reply-To header less error prone Michal Sojka
2014-07-13 14:54 ` David Bremner [this message]
2014-08-10 19:49 ` [PATCH 0/2] Improve message threading Tomi Ollila
2014-08-17 0:49 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761j1fgw7.fsf@maritornes.cs.unb.ca \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=sojkam1@fel.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).