unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] cli/count: apply uncrustify changes
Date: Wed, 09 Sep 2015 20:18:28 -0300	[thread overview]
Message-ID: <87613j41x7.fsf@zancas.localnet> (raw)
In-Reply-To: <87613jpkam.fsf@zancas.localnet>

David Bremner <david@tethera.net> writes:

> Tomi Ollila <tomi.ollila@iki.fi> writes:
>
>>>  
>>>      if (exclude == EXCLUDE_TRUE) {
>>>  	search_exclude_tags = notmuch_config_get_search_exclude_tags
>>> -	    (config, &search_exclude_tags_length);
>>> +				  (config, &search_exclude_tags_length);
>>
>> With the first 2 uncrustify does a good job, but this last one it disagrees
>> how emacs(1) indents (and how it is currently indented in other notmuch
>> source files) -- I'd leave the last (3rd) change out.
>
> I actually think the uncrustify version is better, but I agree there is
> not much point having a standard that isn't easily achievable with
> emacs.  After a short struggle trying to understand CC-mode indentation,
> I give up.

Pushed these two, amended as Tomi suggested.

d

      reply	other threads:[~2015-09-09 23:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-07 13:33 [PATCH 1/2] cli/count: remove unused argument handling for output=modifications David Bremner
2015-09-07 13:33 ` [PATCH 2/2] cli/count: apply uncrustify changes David Bremner
2015-09-07 13:55   ` Tomi Ollila
2015-09-09 17:36     ` David Bremner
2015-09-09 23:18       ` David Bremner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87613j41x7.fsf@zancas.localnet \
    --to=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    --cc=tomi.ollila@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).