unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>,
	Johannes Schauer <josch@debian.org>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] lib: content disposition values are not case-sensitive
Date: Thu, 19 Nov 2015 07:57:11 -0400	[thread overview]
Message-ID: <87610yp5go.fsf@zancas.localnet> (raw)
In-Reply-To: <1443260122-5122-1-git-send-email-jani@nikula.org>

Jani Nikula <jani@nikula.org> writes:

> Per RFC 2183, the values for Content-Disposition values are not
> case-sensitive. While at it, use the gmime function for getting at the
> disposition string instead of referencing the field directly.

I pushed these two, along with the working test from my patch.

If someone actually has a fix for the other test, we can return to
discussing whether it's a bug or not.

d

      parent reply	other threads:[~2015-11-19 11:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150917070056.1941.94846@localhost>
     [not found] ` <20150917083612.1941.22480@localhost>
2015-09-17  8:39   ` [bug] notmuch requires Content-Disposition mime header value to be lower case Johannes Schauer
2015-09-18 12:03     ` David Bremner
2015-09-18 12:37       ` Johannes Schauer
2015-09-18 13:26         ` David Bremner
2015-09-26  8:59           ` Jani Nikula
2015-09-26  9:35           ` [PATCH 1/2] lib: content disposition values are not case-sensitive Jani Nikula
2015-09-26  9:35             ` [PATCH 2/2] cli: " Jani Nikula
2015-10-06 10:20               ` [WIP] tests: add test for case insensitive Content-Disposition David Bremner
2015-10-18 11:58                 ` Jani Nikula
2015-10-18 12:05                   ` Johannes Schauer
2015-11-19 11:57             ` David Bremner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87610yp5go.fsf@zancas.localnet \
    --to=david@tethera.net \
    --cc=jani@nikula.org \
    --cc=josch@debian.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).