From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 183F66DE176C
 for <notmuch@notmuchmail.org>; Mon,  4 Jan 2016 18:33:19 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: -0.31
X-Spam-Level: 
X-Spam-Status: No, score=-0.31 tagged_above=-999 required=5 tests=[AWL=0.241, 
 RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 02vDvfdC8VtQ for <notmuch@notmuchmail.org>;
 Mon,  4 Jan 2016 18:33:16 -0800 (PST)
Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
 by arlo.cworth.org (Postfix) with ESMTPS id 978266DE176A
 for <notmuch@notmuchmail.org>; Mon,  4 Jan 2016 18:33:16 -0800 (PST)
Received: from remotemail by fethera.tethera.net with local (Exim 4.84)
 (envelope-from <david@tethera.net>)
 id 1aGHQl-0003GA-DP; Mon, 04 Jan 2016 21:33:03 -0500
Received: (nullmailer pid 2722 invoked by uid 1000);
 Tue, 05 Jan 2016 02:33:09 -0000
From: David Bremner <david@tethera.net>
To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/3] emacs: Fix mail composition under Emacs 23
In-Reply-To: <1451753265-26713-2-git-send-email-sojkam1@fel.cvut.cz>
References: <1451753265-26713-1-git-send-email-sojkam1@fel.cvut.cz>
 <1451753265-26713-2-git-send-email-sojkam1@fel.cvut.cz>
User-Agent: Notmuch/0.21+26~g9404723 (http://notmuchmail.org) Emacs/24.5.1
 (x86_64-pc-linux-gnu)
Date: Mon, 04 Jan 2016 22:33:09 -0400
Message-ID: <8760z8ah7e.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jan 2016 02:33:19 -0000

Michal Sojka <sojkam1@fel.cvut.cz> writes:

> +    (when return-action (nconc args '(return-action)))
> +    (apply 'message-setup-1
> +	   ;; The following sexp is copied from `message-mail'

> +	   (nconc
> +	    `((To . ,(or to "")) (Subject . ,(or subject "")))

I missed this the first time, but I a bit worried about this used of
nconc. It seems to fall under "A common pitfall is to use a quoted
constant list as a non-last argument to =E2=80=98nconc=E2=80=99"  (from the=
 elisp
manual).  In any case it's not really performance critical code (I
guess?) so maybe we could just use append?

The other use of nconc is more understandable to me.