unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, Damien Cassou <damien@cassou.me>,
	notmuch@notmuchmail.org
Subject: Re: notmuch-reply doesn't use Reply-To
Date: Wed, 23 Mar 2016 07:35:12 -0300	[thread overview]
Message-ID: <8760wdlbxb.fsf@zancas.localnet> (raw)
In-Reply-To: <87twnygmps.fsf@nikula.org>

Jani Nikula <jani@nikula.org> writes:

>>
>> Here is the reply message, and it does not contain the address in Reply-To.
>
> This was true way back when notmuch reply only knew about reply all. For
> --reply-to=sender, it's broken. The simplest "fix" might be
>
> diff --git a/notmuch-reply.c b/notmuch-reply.c
> index 6df54fc992bb..ed0f9cca5c00 100644
> --- a/notmuch-reply.c
> +++ b/notmuch-reply.c
> @@ -334,7 +334,7 @@ add_recipients_from_message (GMimeMessage *reply,
>       * that the address in the Reply-To header will always appear in
>       * the reply.
>       */
> -    if (reply_to_header_is_redundant (message)) {
> +    if (reply_to_header_is_redundant (message) && reply_all) {
>         reply_to_map[0].header = "from";
>         reply_to_map[0].fallback = NULL;
>      }

I'm going to mark this fixed for now, since the docs have now been
updated to match the behaviour.

d

      parent reply	other threads:[~2016-03-23 10:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-03 16:28 notmuch-reply doesn't use Reply-To Damien Cassou
2015-12-04 12:07 ` David Bremner
2015-12-04 12:14 ` David Bremner
2015-12-04 15:06   ` Tomi Ollila
2015-12-04 16:40   ` Damien Cassou
2015-12-04 17:14     ` David Bremner
2015-12-04 17:14     ` Jani Nikula
2015-12-29 21:54       ` Michal Sojka
2015-12-29 21:55         ` [PATCH] doc/reply: Clarify how reply-to header is handled Michal Sojka
2016-03-14 23:39           ` David Bremner
2016-03-23 10:35       ` David Bremner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8760wdlbxb.fsf@zancas.localnet \
    --to=david@tethera.net \
    --cc=damien@cassou.me \
    --cc=jani@nikula.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).