From: David Bremner <david@tethera.net>
To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] tests: account for varying-size OpenPGP signatures
Date: Wed, 23 Nov 2016 12:59:38 -0400 [thread overview]
Message-ID: <8760neku85.fsf@tesseract.cs.unb.ca> (raw)
In-Reply-To: <20161123164112.27847-1-dkg@fifthhorseman.net>
Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
> @@ -37,7 +37,8 @@ test_expect_success 'emacs delivery of signed message' \
> test_begin_subtest "signature verification"
> output=$(notmuch show --format=json --verify subject:"test signed message 001" \
> | notmuch_json_show_sanitize \
> - | sed -e 's|"created": [1234567890]*|"created": 946728000|')
> + | sed -e 's|"created": [1234567890]*|"created": 946728000|' \
> + -e 's/"content-length": [1-9][0-9]*/"content-length": "NONZERO"/')
there are a bunch of sed oneliners (or perl equivalent) collected in
test-lib.sh as functions test_*_sanitize. I wonder if that would be
worthwhile here, to have one place to update regexps etc... Something
in the style of notmuch_show_sanitize wrapping a call to
notmuch_json_show_sanitize
next prev parent reply other threads:[~2016-11-23 16:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 19:22 T350 test failures with gnupg-2.1.16 Marius Bakke
2016-11-22 19:59 ` David Bremner
2016-11-22 20:12 ` Marius Bakke
2016-11-22 20:36 ` David Bremner
2016-11-22 21:20 ` Marius Bakke
2016-11-22 20:49 ` Daniel Kahn Gillmor
2016-11-22 23:07 ` Daniel Kahn Gillmor
2016-11-22 23:20 ` Marius Bakke
2016-11-23 16:41 ` [PATCH] tests: account for varying-size OpenPGP signatures Daniel Kahn Gillmor
2016-11-23 16:59 ` David Bremner [this message]
2016-11-23 17:58 ` Daniel Kahn Gillmor
2016-11-23 17:57 ` [PATCH v2] tests: account for varying-size cryptographic signatures Daniel Kahn Gillmor
2016-11-25 1:27 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760neku85.fsf@tesseract.cs.unb.ca \
--to=david@tethera.net \
--cc=dkg@fifthhorseman.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).