From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 81F3F6DE00C4 for ; Fri, 1 Dec 2017 17:56:11 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[AWL=0.011, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6ANubkWpxh04 for ; Fri, 1 Dec 2017 17:56:10 -0800 (PST) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 7D6C46DE00AC for ; Fri, 1 Dec 2017 17:56:10 -0800 (PST) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1eKx2D-0003Vt-Jw; Fri, 01 Dec 2017 20:56:05 -0500 Received: (nullmailer pid 11779 invoked by uid 1000); Sat, 02 Dec 2017 01:56:04 -0000 From: David Bremner To: Daniel Kahn Gillmor , Notmuch Mail Subject: Re: [PATCH 15/18] crypto: actually stash session keys when try-decrypt=true In-Reply-To: <87tvxb3gkn.fsf@fifthhorseman.net> References: <20171025065203.24403-1-dkg@fifthhorseman.net> <20171025065203.24403-16-dkg@fifthhorseman.net> <87tvxu8jwl.fsf@tethera.net> <87tvxb3gkn.fsf@fifthhorseman.net> Date: Fri, 01 Dec 2017 21:56:04 -0400 Message-ID: <87609px58r.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Dec 2017 01:56:11 -0000 Daniel Kahn Gillmor writes: > On Thu 2017-11-16 08:53:14 -0400, David Bremner wrote: >> I'd be happier if we didn't further entrench the text format in the test >> suite. How hard would it be to use json output (+maybe python?) here? > > json output seems clunkier to me, and i don't think it's necessary for > the purposes of these tests. Using python here isn't possible without > updating the python bindings to accomodate decryption policy, which > doesn't come until later in the series. > > so i'd prefer to leave it as-is, but i wouldn't object if someone wanted > to propose a good patch to these tests that uses json. > > --dkg At some point I had the idea that we should get rid of the text output format. Looking at e.g. notmuch-show.c the stuff related to text output is not as ad hoc as I remember, so maybe I should just give up on that idea. d