From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 2CC6D6DE0183 for ; Sun, 4 Feb 2018 17:22:09 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.007 X-Spam-Level: X-Spam-Status: No, score=-0.007 tagged_above=-999 required=5 tests=[AWL=-0.007] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1v2Mk1hn9cak for ; Sun, 4 Feb 2018 17:22:06 -0800 (PST) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTPS id 7EF6F6DE010F for ; Sun, 4 Feb 2018 17:22:06 -0800 (PST) Received: from fifthhorseman.net (ool-6c3a0662.static.optonline.net [108.58.6.98]) by che.mayfirst.org (Postfix) with ESMTPSA id DEAC3F99A; Sun, 4 Feb 2018 20:22:03 -0500 (EST) Received: by fifthhorseman.net (Postfix, from userid 1000) id C9D6120529; Sun, 4 Feb 2018 20:09:48 -0500 (EST) From: Daniel Kahn Gillmor To: David Bremner , Notmuch Mail Subject: Re: [PATCH] remove debian-build/ and its children when cleaning after debian package In-Reply-To: <87zi4oxoiv.fsf@tethera.net> References: <20180204204241.25008-1-dkg@fifthhorseman.net> <87zi4oxoiv.fsf@tethera.net> Date: Sun, 04 Feb 2018 20:09:45 -0500 Message-ID: <87607c1bty.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 01:22:09 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sun 2018-02-04 20:34:32 -0400, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> --- >> debian/clean | 1 + >> 1 file changed, 1 insertion(+) >> create mode 100644 debian/clean >> >> diff --git a/debian/clean b/debian/clean >> new file mode 100644 >> index 00000000..c5797567 >> --- /dev/null >> +++ b/debian/clean >> @@ -0,0 +1 @@ >> +debian-build/ >> --=20 > > That seems to be something specific to git-buildpackage. The > gbp-buildpackage man page claims that the default is to remove that > directory after building. Perhaps someone more familiar with > git-buildpackage can figure out why that's not happening. agreed, it is specific to git-buildpackage because of the following two lines in debian/gbp.conf: # Directory for performing the build export-dir =3D ./debian-build if gbp removed the directory after building, though, there would be no artifacts left to review, sign or upload. so that doesn't make sense either. those lines have been there since 2608bfe95 (in 2010) when debian/gbp.conf was created. maybe the right thing is just to remove them, so that gbp buildpackage will default to whatever the user's default build location is? (usually ../, iiuc). Any objections to removing the export-dir directive from gbp.conf? --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEzicvlOwymaWlnoHjyu+ogyFnUzMFAlp3rtkACgkQyu+ogyFn UzNyARAAwth0bm4R1CAazW7uOxZXtRJ4RvTw+k+vT1SItyaOq+cGQYvN1IwVszeu fT5Q/aMTTec44aYNgsuEXEJa/QU9FL4XccY+hqGMB2/u0KLhW43Ven/2cssXbDbQ CXhmwtb2NkGXLJ8Z7NtEnWqCgQZIp6r6s7k6izRT6bQlawQGvnjcs4ZgWC6jUIHb NxluMa+9dS4dyH62MhpNsEIsvHxtsNhxiBMpKG3gvNoj9aQOa7RulmuoYF+sDNdX GnvpMaf1tq0f5NCwJkZ06W+dtXcr9Zvgo4vjvEhiwIsrsKDbrq/MYoH70zwWfo66 T5+rtuGyXoeJSPMURjSS6XGa95xFyLyCf8MmP1NnRI3JjVjMlcu+ypHjnAp9o9K1 qoX+aVLoEgseOQNVeHBjDHeXvM2ZjWScdX2kyoILVIWZ17PCPI9Cdx8fkokmh4Qu WZ9doWbjljh9KJx5BSBn11sFAMd2MfV9XMDZZxeCh1n4DSxEm4NBpaqjErkzSG+C lkSOZHR3ZRrmCbvIOnBwqdMxJp7L5EFGM9ApDiI3jAfnushFNIUlDvW+gh2sPVpc KiZjkQJdqKwpIvHM84NZTf+6RZl/biKc+fzrMRQUYbOvgSMEOrcGVWnpAzDYAbBO Db5b+1TRCja8cc3lG6GmK0IAnZ3FF/Cic1Pv7/gczilKgguwg5I= =flmJ -----END PGP SIGNATURE----- --=-=-=--