From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: David Bremner <david@tethera.net>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] remove debian-build/ and its children when cleaning after debian package
Date: Sun, 04 Feb 2018 20:09:45 -0500 [thread overview]
Message-ID: <87607c1bty.fsf@fifthhorseman.net> (raw)
In-Reply-To: <87zi4oxoiv.fsf@tethera.net>
[-- Attachment #1: Type: text/plain, Size: 1342 bytes --]
On Sun 2018-02-04 20:34:32 -0400, David Bremner wrote:
> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>
>> ---
>> debian/clean | 1 +
>> 1 file changed, 1 insertion(+)
>> create mode 100644 debian/clean
>>
>> diff --git a/debian/clean b/debian/clean
>> new file mode 100644
>> index 00000000..c5797567
>> --- /dev/null
>> +++ b/debian/clean
>> @@ -0,0 +1 @@
>> +debian-build/
>> --
>
> That seems to be something specific to git-buildpackage. The
> gbp-buildpackage man page claims that the default is to remove that
> directory after building. Perhaps someone more familiar with
> git-buildpackage can figure out why that's not happening.
agreed, it is specific to git-buildpackage because of the following two
lines in debian/gbp.conf:
# Directory for performing the build
export-dir = ./debian-build
if gbp removed the directory after building, though, there would be no
artifacts left to review, sign or upload. so that doesn't make sense
either.
those lines have been there since 2608bfe95 (in 2010) when
debian/gbp.conf was created. maybe the right thing is just to remove
them, so that gbp buildpackage will default to whatever the user's
default build location is? (usually ../, iiuc).
Any objections to removing the export-dir directive from gbp.conf?
--dkg
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-02-05 1:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-04 20:42 [PATCH] remove debian-build/ and its children when cleaning after debian package Daniel Kahn Gillmor
2018-02-05 0:34 ` David Bremner
2018-02-05 1:09 ` Daniel Kahn Gillmor [this message]
2018-02-05 12:21 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87607c1bty.fsf@fifthhorseman.net \
--to=dkg@fifthhorseman.net \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).