From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 3CC7C6DE00C6 for ; Tue, 1 May 2018 10:47:54 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.021 X-Spam-Level: X-Spam-Status: No, score=-0.021 tagged_above=-999 required=5 tests=[AWL=-0.021, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 16N9vchSRV7I for ; Tue, 1 May 2018 10:47:53 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTPS id 4695E6DE00B4 for ; Tue, 1 May 2018 10:47:53 -0700 (PDT) Received: from fifthhorseman.net (unknown [38.109.115.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id B2F83F99A; Tue, 1 May 2018 13:47:50 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 21DA02045D; Tue, 1 May 2018 13:42:02 -0400 (EDT) From: Daniel Kahn Gillmor To: David Bremner , Notmuch Mail Subject: Re: [PATCH 1/5] crypto: prepare for decryption of inline PGP encrypted messages In-Reply-To: <87zi1kgbtr.fsf@tethera.net> References: <20171212071553.6440-1-dkg@fifthhorseman.net> <20171212071553.6440-2-dkg@fifthhorseman.net> <8736zdgcnb.fsf@tethera.net> <87zi1kgbtr.fsf@tethera.net> Date: Tue, 01 May 2018 13:42:01 -0400 Message-ID: <876047qnme.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2018 17:47:54 -0000 On Mon 2018-04-30 08:42:24 -0300, David Bremner wrote: > David Bremner writes: > >> Daniel Kahn Gillmor writes: >> >>> We make use here of GMime's optimization function for detecting the >>> presence of inline PGP encrypted content, which is only found in GMime >>> 3.0 or later. >> >> We nominally support gmime-2.6 still. Maybe we shouldn't anymore, but >> that's a different discussion. Does this series compile and fail >> gracefully with gmime 2.6? > > Looking at the rest of the series, it looks like it at least tries > to. So maybe it's just the commit message of the first commit that is > confusing, since the commit has nothing that looks like it handles gmime > 2.6. I think the point was that this is making use of features only found in gmime 3.0. so if you build against 2.6, the functionality is absent, but it shouldn't cause breakage. --dkg