From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: Thomas Schneider <qsx@chaotikum.eu>, David Bremner <david@tethera.net>
Cc: notmuch@notmuchmail.org
Subject: Re: Indentation style
Date: Sun, 28 Jul 2019 20:56:28 -0400 [thread overview]
Message-ID: <875znlvetf.fsf@fifthhorseman.net> (raw)
In-Reply-To: <875znlol8b.fsf@chaotikum.eu>
[-- Attachment #1: Type: text/plain, Size: 1558 bytes --]
On Mon 2019-07-29 00:19:48 +0200, Thomas Schneider wrote:
> Maybe I misunderstood, but this doesn’t really look like Emacs’ defaults
> for C.
I think the question is less "emacs defaults" vs. "consistency with the
current codebase".
> While we’re at it, how about a generic .editorconfig? The world isn’t
> split into good people and dea… uh, Emacs and Vim.
Anyone who submits a .editorconfig that allows us to drop .dir-locals.el
would get enthusiastic support from me. notmuch has been a very
emacs-focused project for years, but it doesn't need to be, and generic
editor configuration rules are preferable to editor-specific rules.
here's what i suspect such an editorconfig would look like given our
current codebase, but i haven't tested it or tried to apply the changes
to the notmuch codebase and see if it changes anything.
----------------------
root = true
end_of_line = lf
insert_final_newline = true
trim_trailing_whitespace = true
charset = utf-8
[*.{c,h,cpp,sh,el}]
tab_width = 8
indent_style = tab
indent_size = 4
----------------------
That said, i don't know how to represent (fill-column . 70) in
editorconfig syntax (see e0d85656da7f4d6e7d0b66a7bece39724143bffe for
justification), or (c-file-style . "linux").
(fwiw, i would also be happy if we moved away from literal tabs and just
used spaces-only. But i am not interested in setting off a flamewar,
so if anyone prefers the mixed-tabs-and-spaces situation we are in
today, i will never mention this again)
--dkg
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2019-07-29 13:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-28 13:33 Indentation style (was: [PATCH] notmuch-dump.c: Fix output file being closed twice) Ralph Seichter
2019-07-28 20:36 ` David Bremner
2019-07-28 22:19 ` Indentation style Thomas Schneider
2019-07-29 0:56 ` Daniel Kahn Gillmor [this message]
2019-07-29 14:52 ` David Bremner
2019-07-29 21:23 ` Tomi Ollila
2019-07-30 13:09 ` Daniel Kahn Gillmor
2019-07-30 13:37 ` Ralph Seichter
2019-07-31 10:58 ` Tomi Ollila
2019-07-29 1:13 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875znlvetf.fsf@fifthhorseman.net \
--to=dkg@fifthhorseman.net \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=qsx@chaotikum.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).