From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4GRPGw+8Hl8EYQAA0tVLHw (envelope-from ) for ; Mon, 27 Jul 2020 11:35:43 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id AKQrFw+8Hl9USwAA1q6Kng (envelope-from ) for ; Mon, 27 Jul 2020 11:35:43 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1DEEF9403AE for ; Mon, 27 Jul 2020 11:35:42 +0000 (UTC) Received: from [144.217.243.247] (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id F2D8227B31; Mon, 27 Jul 2020 07:35:35 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id B94C91FA17 for ; Mon, 27 Jul 2020 07:35:33 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 82AFB60AB8; Mon, 27 Jul 2020 07:35:33 -0400 (EDT) Received: (nullmailer pid 1786857 invoked by uid 1000); Mon, 27 Jul 2020 11:34:43 -0000 From: David Bremner To: Jonas Bernoulli , notmuch@notmuchmail.org Subject: Re: [PATCH 2/3] test: Deal with Emacs 27 switching to lexical scope by default In-Reply-To: <20200726212610.15893-3-jonas@bernoul.li> References: <20200724180924.21944-1-jonas@bernoul.li> <20200726212610.15893-1-jonas@bernoul.li> <20200726212610.15893-3-jonas@bernoul.li> Date: Mon, 27 Jul 2020 08:34:43 -0300 Message-ID: <875za9ry24.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: T3MTEH46VADDMORYB7GGZFVSDH2OWQRB X-Message-ID-Hash: T3MTEH46VADDMORYB7GGZFVSDH2OWQRB X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: -0.97 X-TUID: LjSNRIQDwMdT Jonas Bernoulli writes: > > +(defvar notmuch-hello-mode-hook-counter -100) > +(defvar notmuch-hello-refresh-hook-counter -100) > + > (defadvice notmuch-search-process-filter (around pessimal activate disable) > "Feed notmuch-search-process-filter one character at a time." > (let ((string (ad-get-arg 1))) This is overall fine, but if you were going to respin the series anyway for something else, then a comment on the unusual initialization values would not go amiss. Out of curiousity, why not nil? d