From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8ByaHDnXMl9RfAAA0tVLHw (envelope-from ) for ; Tue, 11 Aug 2020 17:36:57 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id sKH2FjnXMl+VdgAAB5/wlQ (envelope-from ) for ; Tue, 11 Aug 2020 17:36:57 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 56091940291 for ; Tue, 11 Aug 2020 17:36:55 +0000 (UTC) Received: from [144.217.243.247] (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 9F3FA27DBC; Tue, 11 Aug 2020 13:36:48 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 303762711E for ; Tue, 11 Aug 2020 13:36:46 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 7B75B5FDE2; Tue, 11 Aug 2020 13:36:44 -0400 (EDT) Received: (nullmailer pid 3035407 invoked by uid 1000); Tue, 11 Aug 2020 17:36:43 -0000 From: David Bremner To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH] notmuch-mutt: replace shell pipeline with internal pipe processing In-Reply-To: <20200727193833.4654-1-tomi.ollila@iki.fi> References: <20200727193833.4654-1-tomi.ollila@iki.fi> Date: Tue, 11 Aug 2020 14:36:43 -0300 Message-ID: <875z9pt784.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: HNGS5ZBJEI632QAIZYHMKRSVE2QDKUTA X-Message-ID-Hash: HNGS5ZBJEI632QAIZYHMKRSVE2QDKUTA X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: tomi.ollila@iki.fi X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: 0.53 X-TUID: 0AYROFoK63X4 Tomi Ollila writes: > The shell pipeline used to symlink files based in search results > to "cache" directory for mutt(1) to use was prone to portability > problems (due to /bin/sh differences). > > The replacement executes `notmuch search` without intermediate shell > (so shell_quote was removed in this case), reads the filenames from > piped output and symlinks files internally. > --- > > Now also tested a bit by me (remoteusage provides stale symlinks ;) tested by the original bug reporter https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=966100#22 seems to work.