From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uKcIJE3I0l/GRwAA0tVLHw (envelope-from ) for ; Fri, 11 Dec 2020 01:15:57 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id aI7aH03I0l+ZXwAAB5/wlQ (envelope-from ) for ; Fri, 11 Dec 2020 01:15:57 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1CA62940481 for ; Fri, 11 Dec 2020 01:15:56 +0000 (UTC) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id BC29C29C71; Thu, 10 Dec 2020 20:15:48 -0500 (EST) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id 2051829C6B for ; Thu, 10 Dec 2020 20:15:46 -0500 (EST) Received: by fethera.tethera.net (Postfix, from userid 1001) id 54DA75FC95; Thu, 10 Dec 2020 20:15:44 -0500 (EST) Received: (nullmailer pid 2640363 invoked by uid 1000); Fri, 11 Dec 2020 01:15:42 -0000 From: David Bremner To: Tomi Ollila , 976934@bugs.debian.org, notmuch@notmuchmail.org Subject: Re: [PATCH] build/docs: move docstring prereq to file targets In-Reply-To: References: <20201210020038.2390525-1-david@tethera.net> Date: Thu, 10 Dec 2020 21:15:42 -0400 Message-ID: <875z59kurl.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: JJH5K2RWAFWV76NF2Y6LE7P65GIAHKR7 X-Message-ID-Hash: JJH5K2RWAFWV76NF2Y6LE7P65GIAHKR7 X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -0.61 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 1CA62940481 X-Spam-Score: -0.61 X-Migadu-Scanner: scn1.migadu.com X-TUID: K2sL3ZoO3J0K Tomi Ollila writes: > On Wed, Dec 09 2020, David Bremner wrote: > >> Under a sufficiently high level of parallelism [1] there seems to be a >> a race condition that allows sphinx-build to start running before the >> docstrings are extracted. This change moves the docstring stamp from >> the phony targets sphinx-html and sphinx-info to the file targets that >> they depend on. I'm not sure why this makes things better, but I am >> fairly confident it does not make things worse, and experimentally it >> seems to eliminate the race condition. > > Good enough for me if this helps. I also don't see reason why that would > make things better (and probably not things worse), just that I got > headache reading that Makefile ;) (and, for example, these particular > targets mentioned would not need to be marked .PHONY...) > > I'd suggest to monitor the behaviour for a while and if things are > consistently better then merge -- such a things when we don't know > enough experience may be enough (or someone(tm) could try to parse make > debug logs ;/) -- or someone(tm) may tell us why that heleps :D I'll try a test upload to Debian and see if that fixes the problem there. I did 2000 builds (sortof by mistake) at -j32 on a 16 thread / 8 core machine, with no crashes. Much less parallelism than the original report, but lots of repetition. d