From: David Bremner <david@tethera.net>
To: Felipe Contreras <felipe.contreras@gmail.com>, notmuch@notmuchmail.org
Cc: Felipe Contreras <felipe.contreras@gmail.com>
Subject: Re: [PATCH] ruby: fix ruby 3.1 warnings
Date: Sat, 17 Apr 2021 09:20:38 -0300 [thread overview]
Message-ID: <875z0lcdbd.fsf@tethera.net> (raw)
In-Reply-To: <20210416202731.72610-1-felipe.contreras@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 621 bytes --]
Felipe Contreras <felipe.contreras@gmail.com> writes:
> init.c:214:5: warning: ‘rb_cData’ is deprecated: by: rb_cObject. Will be removed in 3.1. [-Wdeprecated-declarations]
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Hi Felipe;
Thanks for the patch. I have a couple of questions / comments
- It doesn't apply against current master (5248f55d5f1). Can you rebase
it?
- What version of ruby is generating those warnings? I don't see it with
ruby 2.7. I guess that's not necessarily a blocker, as long as the
patched version still builds and runs with older ruby.
d
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2021-04-17 12:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 20:27 [PATCH] ruby: fix ruby 3.1 warnings Felipe Contreras
2021-04-17 12:20 ` David Bremner [this message]
2021-04-18 22:54 ` Felipe Contreras
2021-04-19 10:14 ` David Bremner
2021-04-19 18:50 ` Tomi Ollila
2021-04-19 20:35 ` Felipe Contreras
2021-05-17 11:54 ` Đoàn Trần Công Danh
2021-05-17 19:14 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z0lcdbd.fsf@tethera.net \
--to=david@tethera.net \
--cc=felipe.contreras@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).