From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CWp4J1m92GB5MQEAgWs5BA (envelope-from ) for ; Sun, 27 Jun 2021 20:03:05 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id YMecIlm92GDGRgAAB5/wlQ (envelope-from ) for ; Sun, 27 Jun 2021 18:03:05 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D9D35276B4 for ; Sun, 27 Jun 2021 20:03:04 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 5FA1B290FD; Sun, 27 Jun 2021 14:02:59 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 743B3290FC for ; Sun, 27 Jun 2021 14:02:56 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 54A255FD21; Sun, 27 Jun 2021 14:02:56 -0400 (EDT) Received: (nullmailer pid 932664 invoked by uid 1000); Sun, 27 Jun 2021 18:02:55 -0000 From: David Bremner To: Felipe Contreras , notmuch@notmuchmail.org Subject: Re: [PATCH 1/3] ruby: add new Database.open_with_config In-Reply-To: <20210604032901.3815539-2-felipe.contreras@gmail.com> References: <20210604032901.3815539-1-felipe.contreras@gmail.com> <20210604032901.3815539-2-felipe.contreras@gmail.com> Date: Sun, 27 Jun 2021 15:02:55 -0300 Message-ID: <875yxz18z4.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: PSGLBNCAZPAOJMLGGG5TZOBWPMQNFIXU X-Message-ID-Hash: PSGLBNCAZPAOJMLGGG5TZOBWPMQNFIXU X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624816985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=YHDeW+iC7SFJrBexrjaTqGsV+T5plFfL/cMv5AHeR5w=; b=ZcJlk5aBHZr58lf/fRUW4vOVzFQsygCdRE7Kr3AeJ040ebVLESCCTUAxwdW1F6wl8OyiIF ayenjGngbFo9rVu6y6prNIKk72o0hfEOHLM/gAl96vVdpckHaile0SphXAAI5/8y0BASFf 2YUy8NnEjNfS9VVWmKC64RhgikGLXCSnoPEqhsmMFURwWRIH+gNCj8cj+QSPz8XtqAzdnC 22wJ4ssIsmXy0D17NNW4WqEPMyn/nVt1WdJ5CT0O5N5YmebBHZ309n7FPa8Vtwn+0SOC3S gX5PkJOIchp46EGs9GYXuhvOAeA9VhqgKk/7Ue62EAyUoVOL4/manTGFFDjMtw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624816985; a=rsa-sha256; cv=none; b=N0nTCiev1sH4T2u3lWvgTBdzcds4YhvyChw4J/w6Oa1mdFjIV4YWy35nXZsep0UsckZorC XTRP/R+hnPdbvz/g7Kjw8wsROI8F2wth4AtM0OGKdUIXqu/UOYl5qNr9auf5yMzGdFub9T fYKOby9Jd3d7L+5hyhTSkX78TqrErDvNvs9th6a6hQPU6IZfQcMQ/MO77fDcW4Bj6orebN sCM6oOINkbMbvzeV5QDGSa91l2adifk6ps5KQV3tqg8VFMvzfZLAGWhzFzBXAlqIFSX7Nd wNViXpOpjsHwiSxAb+eAuxYCabPwyMGWPirU6aHYMCqX1Ts70W77ihr46YVZrA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.07 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: D9D35276B4 X-Spam-Score: -2.07 X-Migadu-Scanner: scn0.migadu.com X-TUID: yywlf2rOqald Felipe Contreras writes: > + ret = notmuch_database_open_with_config (database_path, mode, > + config_path, profile, &db, > + NULL); I'm curious why you ignore the error_message ouput parameter. Of course it's valid and supported for library users to do this, but this way there is no way for users of the ruby bindings to retrieve the additional information about the error. Particularly in the case of Xapian exceptions, this can be helpful for debugging.