From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id IAKtCHqUvGEDTQEAgWs5BA (envelope-from ) for ; Fri, 17 Dec 2021 14:45:30 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id mFlLBHqUvGGQSQAAbx9fmQ (envelope-from ) for ; Fri, 17 Dec 2021 13:45:30 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D34B7C7FC for ; Fri, 17 Dec 2021 14:45:29 +0100 (CET) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 05834297ED; Fri, 17 Dec 2021 08:45:26 -0500 (EST) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id C44DA297EB for ; Fri, 17 Dec 2021 08:45:23 -0500 (EST) Received: by fethera.tethera.net (Postfix, from userid 1001) id A8D6E5FC42; Fri, 17 Dec 2021 08:45:23 -0500 (EST) Received: (nullmailer pid 3520740 invoked by uid 1000); Fri, 17 Dec 2021 13:45:22 -0000 From: David Bremner To: Ryan Schmidt , notmuch@notmuchmail.org Subject: Re: Fix order of -I and -L flags In-Reply-To: <7851CAB5-4556-4931-A0A2-37003E56C927@ryandesign.com> References: <7851CAB5-4556-4931-A0A2-37003E56C927@ryandesign.com> Date: Fri, 17 Dec 2021 09:45:22 -0400 Message-ID: <875yrnny4t.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: 5IL2ZS7L4SODECFYZOSUE7XAQ6SMYYVV X-Message-ID-Hash: 5IL2ZS7L4SODECFYZOSUE7XAQ6SMYYVV X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: FR ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639748729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=XqggW6ptiVDaKLqbKmiUhajNn8QKPEmkzZuiXLBWbf8=; b=HBxLsqSsX2okpMxyEXqdqwaGH3RKsDxT7K5u6ocq6AEdiyHHhy7Gtpx1iPvltA9SWJsJ+N v+DzJpQOjecHNjABCIqxJPme3eKSTSDPnq5apHY8DjUVr5ncjsReEXbkliyrwqohtEQfQ3 bTo8Upmg0qLPbZY/fixsKM953FfKG+Sc18obQuMD5X0gds5zTbKCuAP6N/tn4G/iegiv3V 5D2p8PsiGV+2PHPyCA+kJR59gvoIJ2jjIOIW/98IA4EvXDykDxf8bUsTDoBSjFIvzbyKKj D0/XltHWV1gY3rRAPhXqROm+zbOBRBLmUwFgS55KLoWMTz07nb5wOTzw+IroNA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639748729; a=rsa-sha256; cv=none; b=D1ehsbFiH/ZDYctfUuGOAptUpNFd/xvP4rhXfVssVsiFV5lfb/jFkma3SnCMC3RYJhOojQ Ev7QxrhFRvNCyd/1GTVFNID7phwNLRXzGLChpQoyOPxIzgFdALfZpWg7/paiQJ2gJujYcS lNRQEPuqg9q2KcskBAkV+HI8t4b628GqBmsaemvBqsyaIAjTyQr7/eHbCrMyA4ohGfCZ2x fIqkB9HbFOUb6I/M1PgtbIxq7FxouI27q7qpBqOPQXbsyfQb1eNh7qZmkkEb3f0O5hzvPA IvNvr8dY7CdTOA1GDqbQDFQz62Fj4U0TnmarVRv72fY1axh8jw7+3R+3ZaobLQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.47 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: D34B7C7FC X-Spam-Score: -2.47 X-Migadu-Scanner: scn0.migadu.com X-TUID: VT18misLkWcO Ryan Schmidt writes: > The notmuch build system puts -I and -L flags in the wrong order. > > Specifically, -I flags the user might specify in the CPPFLAGS > environment variable appear before the -I flags for the project's own > directories, resulting in build failure if a previous version of > notmuch (whose headers differ sufficiently from the new version) was > already installed. > > https://trac.macports.org/ticket/63274 > > Similarly, -L flags the user might specify in the LDFLAGS environment > variable appear before the -L flags for the project's own directories, > resulting in build failure if a previous version of notmuch (whose > libraries differ sufficiently from the new version) was already > installed. > > https://trac.macports.org/ticket/63665 Although I don't consider GNU standards normative for notmuch, there is some value in doing things a standard way. In particular the way notmuch uses {C,CPP,LD,CXX}FLAGS follows e.g. [1]. I guess on the Linux / BSD side we expect the configure script to do the heavy lifting so that manual setting of CPPFLAGS / LDFLAGS at build time is not needed in general. So one question is why isn't this the case for macports? I think there is value in letting individual end-users use these variables to override things (we just saw a case the other day where that fixed someone's unique build problem). I'm open to ideas for how we can make things easier for macports without taking away existing functionality for other users. d [1]: https://www.gnu.org/prep/standards/html_node/Command-Variables.html.