From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id IPmfALUKwWGZTgEAgWs5BA (envelope-from ) for ; Mon, 20 Dec 2021 23:59:01 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id gJruN7QKwWGwGQAAB5/wlQ (envelope-from ) for ; Mon, 20 Dec 2021 22:59:00 +0000 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BB2B392EB for ; Mon, 20 Dec 2021 23:59:00 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id BF8CE5F704; Mon, 20 Dec 2021 22:58:56 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id 482D55F701 for ; Mon, 20 Dec 2021 22:58:54 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id A7B6C5FC42; Mon, 20 Dec 2021 17:58:52 -0500 (EST) Received: (nullmailer pid 573997 invoked by uid 1000); Mon, 20 Dec 2021 22:58:51 -0000 From: David Bremner To: Tomi Ollila , Ryan Schmidt , notmuch@notmuchmail.org Subject: Re: Fix order of -I and -L flags In-Reply-To: References: <7851CAB5-4556-4931-A0A2-37003E56C927@ryandesign.com> <875yrnny4t.fsf@tethera.net> Date: Mon, 20 Dec 2021 18:58:51 -0400 Message-ID: <875yrinas4.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: Z4PI2D6MYGSMSDTKBXZMGZP2LDUCKCRY X-Message-ID-Hash: Z4PI2D6MYGSMSDTKBXZMGZP2LDUCKCRY X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640041140; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=ZiKaTgh/6jy+LlaxUUuItw0wbVEoyTT12aNd/PuguAA=; b=eF3vlv53isHmYROQ2T9+iT9t3GLQHx0IiavAUXOyVR8e6DeGcvYGuS0uKSr9jf/5K89qVH rrbXQmFgnfeazYvXaw5oudE+tcHtdBIHqQ6pM5SBsVxkmHLd2LfVnfB0Js98cyZhRk0fED 0S+BFZvV30DIIaZpOuetGaCxFeKc3aMJxoUAMHXgtJrfQ8KXYkCeZxcHy8rYBn1dwgTthW qgOuHzeLokv58UEAscpedHbGOO7Agsx5Hwl9Z53vxjW4GSThVNSfnxSHURNEIxul9U32as PqRkHMb9WpUE/56uMtn4vi2N6yn16QrqBoaw/ks5pFF2cr57mpyh+YiwMVoY5w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640041140; a=rsa-sha256; cv=none; b=dQIKxqO2g5jDHEQZ8oJhVSYkH22pfABn5PLl9wNB3pO+JarbMdTRDSPs2EYBUIFWxLX76b Mi8a6zHNRaBv218fWr5SPG7OfyHd8XVWR+tun3wKx6XKCgDCczHz8QZAy+YtuaRm1zhZRF 1eq0kQLw1PvnHIUhBiWeZm+LT5qCzM27BZavo3yyLFYqEZ4fhoyxnbihHOTE14i2GvUS6q 8yN2wuGttH7ruULcVQ+OEk/xSSufdzfs4xF60eSRjhVBtW+85EnejQBJVk0rVGInyW3ReM refGzOkyEEGjV8mI/PhieR+ht5PyAgJaWoJm8Pan30AWcFnOaiNpkirWuFmHxA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=fail (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org does not designate 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.45 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=fail (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org does not designate 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: BB2B392EB X-Spam-Score: -1.45 X-Migadu-Scanner: scn0.migadu.com X-TUID: 89hEYyupsHEM Tomi Ollila writes: > On Fri, Dec 17 2021, David Bremner wrote: >> >> Although I don't consider GNU standards normative for notmuch, there is >> some value in doing things a standard way. In particular the way notmuch >> uses {C,CPP,LD,CXX}FLAGS follows e.g. [1]. > > Does it ? > > I initially thought CFLAGS should be first so that user can modify > anything, but then I thought that CFLAGS should be last just so that > the "project internal" includes are taken first. > "Put CFLAGS last in the compilation command, after other variables > containing compiler options, so the user can use CFLAGS to override the > others. " That's a good point. I was thinking about CPPFLAGS, because of Ryan's original question(s). > > ^^ that would also say mean that the -I's and -L's given in ${CFLAGS} > would be effective after the -I's and -L' configured... > >> >> I guess on the Linux / BSD side we expect the configure script to do the >> heavy lifting so that manual setting of CPPFLAGS / LDFLAGS at build time >> is not needed in general. So one question is why isn't this the case for >> macports? >> >> I think there is value in letting individual end-users use these >> variables to override things (we just saw a case the other day where >> that fixed someone's unique build problem). > > What was the case ? > using LDFLAGS id:87lf0thhft.fsf@tethera.net I have to admit I'm a bit fuzzy on how LDFLAGS work. I would imagine that -L works left to right like -I, but I'm too lazy to check right now. >> I'm open to ideas for how we can make things easier for macports without >> taking away existing functionality for other users. > > Would putting CFLAGS last break someone's workflow? Did I understand > correctly what [1] mean for use of CFLAGS ? > I think you're right, but I think it won't help Ryan. >> >> [1]: https://www.gnu.org/prep/standards/html_node/Command-Variables.html. > > > Tomi