From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uGVcA0Gu7GFJvAAAgWs5BA (envelope-from ) for ; Sun, 23 Jan 2022 02:24:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id WHZuO0Cu7GGJ1gAAauVa8A (envelope-from ) for ; Sun, 23 Jan 2022 02:24:16 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C796B34799 for ; Sun, 23 Jan 2022 02:24:16 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 008DB5F714; Sun, 23 Jan 2022 01:24:12 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id BDC6C5F401 for ; Sun, 23 Jan 2022 01:24:08 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 530EB5FC01; Sat, 22 Jan 2022 20:24:07 -0500 (EST) Received: (nullmailer pid 1741954 invoked by uid 1000); Sun, 23 Jan 2022 01:24:06 -0000 From: David Bremner To: Austin Ray Subject: Re: v2 fix leaks in n_d_open_with_config In-Reply-To: <20220122205416.nbxqdcapjab62iln@athena> References: <20220109143805.3682660-1-david@tethera.net> <20220122205416.nbxqdcapjab62iln@athena> Date: Sat, 22 Jan 2022 21:24:06 -0400 Message-ID: <875yqb453d.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: YJ7V2FZEFYCLYEINHLKLWUM55WWZE26V X-Message-ID-Hash: YJ7V2FZEFYCLYEINHLKLWUM55WWZE26V X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: notmuch@notmuchmail.org X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642901056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=ZlSYeI4yxpjr7tUJ0Uv57dvteCG32dr8Zi9in6+d0dw=; b=B/Lix4xcqFWEhoaYls1AoL+v3fBBZUFGCQW/r6IzQuV+FjNvUnJ1FPgXDB1py3BSXJeP5E kZ4nozxOFckbt3SjQsSEIQNWBb43SOxWy2EmvQnKAUZ5jiyuuAhfIqmCrbrDZwWhyfM9dS ykwWWxi/iA0su4oIaeFP9+3qjBEUN1ibIv1vD7lR67Ty6vfgTtvrC5PipnkG8Pj467acgd Ls7X2Gq4biqxfe1BbiM2/2NPudwaSYsi0QDVbDvT4FjsgwlJ0AXOwAwsS/GlxrNX2Ls6BE oNGAD/VH24YlF+yITiU6Jj0d5WeJiG+tMgYaUbx6RjUyXv3MxbwpEVlRGAZi0Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642901056; a=rsa-sha256; cv=none; b=Us9jwx12l1VfgAgTt3zb49Qjto/yKZQHgZA9E8wa3Nac0pqY8I8TZj3LuLV8+/jUYd649u EEImpQGfyC1fT8ES4p/aeQz0tTPVcIf49RBOEbyKL6nbfQV29ktbUK7R1K1g3x7GM/rZj4 cGkUFjECKJ7GFrTrp2JAVj34R5mHfGAk+kQ+zsdWffSeXg2s3ieQGmCYFF/imsb+JoOWAu QFS+Rz7IAxIWbA9tqSPl9di1jnF6uuZ3ha+0HxXrZwWmycs9/2zjfyallKCuOovbEhgJXs vIhu8rp9rFjUSV420j915Y/JgyziQdtGp9G6ymdt5VOZEOfmcD/jWASQ6ZBJvQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.35 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: C796B34799 X-Spam-Score: -2.35 X-Migadu-Scanner: scn1.migadu.com X-TUID: 7lQczHv/Q52N Austin Ray writes: > I can confirm this fixes the leak on my end. Thanks! > >> I'm slightly worried that ASAN tests will prove to be flaky. > > If I recall correctly, the Chromium project runs ASAN in their CI > pipelines and it's pretty stable. Hopefully that's some evidence towards > their stability. Series applied to master. I guess we'll just have to see about the ASAN tests. It would be nice to have more memory checking in the test suite if it works out. d