From: David Bremner <david@tethera.net>
To: Austin Ray <austin@austinray.io>
Cc: notmuch@notmuchmail.org
Subject: Re: v2 fix leaks in n_d_open_with_config
Date: Sat, 22 Jan 2022 21:24:06 -0400 [thread overview]
Message-ID: <875yqb453d.fsf@tethera.net> (raw)
In-Reply-To: <20220122205416.nbxqdcapjab62iln@athena>
Austin Ray <austin@austinray.io> writes:
> I can confirm this fixes the leak on my end. Thanks!
>
>> I'm slightly worried that ASAN tests will prove to be flaky.
>
> If I recall correctly, the Chromium project runs ASAN in their CI
> pipelines and it's pretty stable. Hopefully that's some evidence towards
> their stability.
Series applied to master. I guess we'll just have to see about the ASAN
tests. It would be nice to have more memory checking in the test suite
if it works out.
d
prev parent reply other threads:[~2022-01-23 1:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-09 14:38 v2 fix leaks in n_d_open_with_config David Bremner
2022-01-09 14:38 ` [PATCH v2 1/4] configure: check for ASAN support David Bremner
2022-01-09 14:38 ` [PATCH v2 2/4] test: add known broken test for memory leaks in open David Bremner
2022-01-09 14:38 ` [PATCH v2 3/4] lib/config: move g_key_File_get_string before continue David Bremner
2022-01-09 14:38 ` [PATCH v2 4/4] lib/database: delete stemmer on destroy David Bremner
2022-01-22 20:54 ` v2 fix leaks in n_d_open_with_config Austin Ray
2022-01-23 1:24 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yqb453d.fsf@tethera.net \
--to=david@tethera.net \
--cc=austin@austinray.io \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).