From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GKZyC9Yy8WGW4QAAgWs5BA (envelope-from ) for ; Wed, 26 Jan 2022 12:39:02 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id gPbVCNYy8WGtLgEA9RJhRA (envelope-from ) for ; Wed, 26 Jan 2022 12:39:02 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 673173D304 for ; Wed, 26 Jan 2022 12:39:01 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id E4D175F707; Wed, 26 Jan 2022 11:38:58 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 4880F5F419 for ; Wed, 26 Jan 2022 11:38:55 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 77D9E5FBD2; Wed, 26 Jan 2022 06:38:54 -0500 (EST) Received: (nullmailer pid 622354 invoked by uid 1000); Wed, 26 Jan 2022 11:38:53 -0000 From: David Bremner To: notmuch@notmuchmail.org Subject: Re: fix Fcc of signed / encrypted messages. In-Reply-To: <20220120123354.3999579-1-david@tethera.net> References: <20220120123354.3999579-1-david@tethera.net> Date: Wed, 26 Jan 2022 07:38:53 -0400 Message-ID: <875yq6bub6.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: R42M2YTXM7ITX5TNHVSBKXTNUMCG4AHM X-Message-ID-Hash: R42M2YTXM7ITX5TNHVSBKXTNUMCG4AHM X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1643197142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=GkJtctOE/vHMT/+V0w2ywDvPvPkIujRJ2/hb/c2WR/M=; b=rlHEESWbg8NK3yh9x0gd9FH6bUDHZ6oChVCN1tXaUyjqTSB3ki14hUCrRpd2iMzbh7hoxK Mo3pbeellhAigXe5xitU8KA1tDEAFy8478UjOpNM1cPeVNubHleYBQ5sNgP1ii1qswvoaf a2iB0/uwQ9BKDqc4nxO53mQ1munN6LxFdH/yKfU432aL7W0yHoHDPkfKdb0kEBf/+fzN6c qzLb0zQ0b6Aqh7KY7Gyc15KZGmSjdFj94EBax6h5FRzaZUWYSZpxtkTUxmDf7smfLfwaqw JymniGOTfZ6a9VSHBcBGcLQvT/0FAMMb/QjUGjQS2FtQKDjkdzSjCHNotx3CzQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1643197142; a=rsa-sha256; cv=none; b=YFgHrG6MsrS31P7R0h2mhJNKzR7p4hTg7GLhjPKuAN27uYilNFJ6SmjLJ0AYNvqZ0r3RVC lTRAhx2WR8hlVSTSaY+U3xGBiDmVH4SnqdSs1uwsTUNQ0MSpOdq/8uFDKmtdYtcTcuRTNm qu3sVl5EpG17fyx1ujTh/HXw2bVbRLaBwH+oKLI2CKmjSa/kbu+a5kKJPiHkzu3q1Bc+bI Uvjl25ItpvCmcBFylQNu6RoiET5r/njjY1T0Oult7/zthb9Lw9rA/r66COFwKSSSQuWhrc JVtapF8HiLGBUdih2A8cJNkBMdd8rmprJ/n9LDsAFBcYqtYDvQnBSgvDl1+L3Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.04 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 673173D304 X-Spam-Score: -2.04 X-Migadu-Scanner: scn0.migadu.com X-TUID: Tpzg9Uhv0nRP David Bremner writes: > It turns out that in the years since dkg reported this bug, larsi > fixed it in message-do-fcc. Since we in our wisdom copied and modified > that function, we missed out on the fix. This series copies the fix > from "upstream". It requires a couple of updates to the test suite. > Other points to notice: it introduces a call to > #'message-clone-locals, and moves the call to > notmuch-maildir-setup-message-for-saving. Updated series (with Tomi's test framework changes) applied to master.