From: Sean Whitton <spwhitton@spwhitton.name>
To: 56442@debbugs.gnu.org
Cc: notmuch@notmuchmail.org, Eric Abrahamsen <eric@ericabrahamsen.net>
Subject: bug#56442: gnus-search-run-search: Hits notmuch command line length limits
Date: Thu, 07 Jul 2022 09:56:05 -0700 [thread overview]
Message-ID: <875yk850be.fsf@athena.silentflame.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]
Hello,
I'm running a pretty innocent notmuch query over a fairly small Maildir:
"((List:debian-devel.lists.debian.org) or ... or
(List:debian-haskell.lists.debian.org) or
(List:debconf-discuss.lists.debian.org)) and (not path:annex/**)"
but gnus-search-run-search fails to return any results. The reason is
that Gnus first runs the query with --output=threads to obtain a list of
thread ids, and then runs another query with --output=files and a query
constructed from the output of the first query: "thread:000000000000d9d0
or thread:000000000000d9e0 or thread:000000000000d268 or ..."
The resulting command fails completely:
emacs: /usr/bin/notmuch: Argument list too long
Instead of running two searches like this, we can just surround the
whole query like this: "thread:{QUERY}". The manual says it's exactly
equivalent:
... the user should think of the query thread:{<something>} as
expanding to all of the thread IDs which match <something>; not‐
much then performs a second search using the expanded query.
This should be faster, too, with only running a single external command.
Here is the patch I'm thinking I'll apply, if anyone has comments.
--
Sean Whitton
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Use-notmuch-thread-operator-instead-of-performing-tw.patch --]
[-- Type: text/x-diff, Size: 3370 bytes --]
From d62398cc27abd317d31d8f07e151a82081444217 Mon Sep 17 00:00:00 2001
From: Sean Whitton <spwhitton@spwhitton.name>
Date: Thu, 7 Jul 2022 09:34:04 -0700
Subject: [PATCH] Use notmuch thread:{} operator instead of performing two
searches
This also avoids some command line length limit problems.
* gnus-search.el
(gnus-search-run-search (engine gnus-search-notmuch)): Delete method.
(gnus-search-indexed-search-command (engine gnus-search-notmuch)):
When searching for threads, wrap whole query in thread:{} operator.
Always use --output=files, never --output=threads.
---
lisp/gnus/gnus-search.el | 46 +++++-----------------------------------
1 file changed, 5 insertions(+), 41 deletions(-)
diff --git a/lisp/gnus/gnus-search.el b/lisp/gnus/gnus-search.el
index 369df81d9b..53b6d1b4c6 100644
--- a/lisp/gnus/gnus-search.el
+++ b/lisp/gnus/gnus-search.el
@@ -1672,43 +1672,6 @@ gnus-search-transform-expression
(format "date:%s.." (notmuch-date (cdr expr))))
(t (ignore-errors (cl-call-next-method))))))
-(cl-defmethod gnus-search-run-search :around ((engine gnus-search-notmuch)
- server query groups)
- "Handle notmuch's thread-search routine."
- ;; Notmuch allows for searching threads, but only using its own
- ;; thread ids. That means a thread search is a \"double-bounce\":
- ;; once to find the relevant thread ids, and again to find the
- ;; actual messages. This method performs the first \"bounce\".
- (if (alist-get 'thread query)
- (with-slots (program proc-buffer) engine
- (let* ((qstring
- (gnus-search-make-query-string engine query))
- (cp-list (gnus-search-indexed-search-command
- engine qstring query groups))
- thread-ids proc)
- (with-current-buffer proc-buffer
- (erase-buffer)
- (setq proc (apply #'start-process (format "search-%s" server)
- proc-buffer program cp-list))
- (while (process-live-p proc)
- (accept-process-output proc))
- (goto-char (point-min))
- (while (re-search-forward
- "^thread:\\([^[:space:]\n]+\\)"
- (point-max) t)
- (cl-pushnew (match-string 1) thread-ids :test #'equal)))
- (cl-call-next-method
- engine server
- ;; If we found threads, completely replace the query with
- ;; our new thread-based one.
- (if thread-ids
- `((query . ,(mapconcat (lambda (thrd)
- (concat "thread:" thrd))
- thread-ids " or ")))
- query)
- nil)))
- (cl-call-next-method engine server query groups)))
-
(cl-defmethod gnus-search-indexed-search-command ((engine gnus-search-notmuch)
(qstring string)
query &optional _groups)
@@ -1721,13 +1684,14 @@ gnus-search-indexed-search-command
(append
(list (format "--config=%s" config-file)
"search"
- (if thread
- "--output=threads"
- "--output=files"))
+ "--output=files")
(unless thread '("--duplicate=1"))
(when limit (list (format "--limit=%d" limit)))
switches
- (list qstring)))))
+ (list (if thread
+ (format "thread:\"{%s}\""
+ (string-replace "\"" "\"\"" qstring))
+ qstring))))))
;;; Mairix interface
--
2.30.2
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
next reply other threads:[~2022-07-07 16:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 16:56 Sean Whitton [this message]
[not found] <875yk850be.fsf__40907.3059143097$1657213041$gmane$org@athena.silentflame.com>
2022-07-09 16:11 ` bug#56442: gnus-search-run-search: Hits notmuch command line length limits Eric Abrahamsen
2022-07-09 18:01 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yk850be.fsf@athena.silentflame.com \
--to=spwhitton@spwhitton.name \
--cc=56442@debbugs.gnu.org \
--cc=eric@ericabrahamsen.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).