From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id UM2dKyYxImRWVQEASxT56A (envelope-from ) for ; Tue, 28 Mar 2023 02:13:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id YJyCKyYxImT2ZgAAauVa8A (envelope-from ) for ; Tue, 28 Mar 2023 02:13:26 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4A73913FF5 for ; Tue, 28 Mar 2023 02:13:26 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id A23425F392; Tue, 28 Mar 2023 00:13:23 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 6B4425DD5A for ; Tue, 28 Mar 2023 00:13:21 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 51CA75FB82; Mon, 27 Mar 2023 20:13:20 -0400 (EDT) Received: (nullmailer pid 2378034 invoked by uid 1000); Tue, 28 Mar 2023 00:13:18 -0000 From: David Bremner To: Felipe Contreras , notmuch@notmuchmail.org Subject: Re: [PATCH 0/3] ruby: get rid of FileNames object In-Reply-To: <20230327215942.13286-1-felipe.contreras@gmail.com> References: <20230327215942.13286-1-felipe.contreras@gmail.com> Date: Mon, 27 Mar 2023 21:13:18 -0300 Message-ID: <875yal7mxt.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: 3JRKGRUD4BYFZOFJXIW4OOXRBEQU7YDG X-Message-ID-Hash: 3JRKGRUD4BYFZOFJXIW4OOXRBEQU7YDG X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Country: DE X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679962406; a=rsa-sha256; cv=none; b=XYrW8igxtyhWJqC/ujc7pZvmI+DVdnCkAJkRGibZD8aZ1LdI93dSO8aQ7TKct6CzQDkp8/ AQScGLL/QO0xNVLfnC7Kp5KO1pRLRRId1EoshXZTgZzOdepVsdlKfTrT5Mxy4MS9UACqXN Ou7xW17d1ZXfMPyhRKGW9Ef6jk1HrcfQVzQNcOZxxb+iQpxBB8volIerKN3QN46FSb+KTM apSuZ4HBau1ecMXqYfDUFNbL3vZgxTBIBvEqam/21VepaNqBr827KM9DWg19UT4T24fYub bYzmvZ4CHdkgrphOBgilzsJM2VI1lg4xJzSCCW5XmqTE2zl2rWsSJgO6MC/HAA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679962406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=oKk2G4sgjyWcw8F+m1cBsoNxFX6gFWfNvUZs2nKGBaw=; b=SM+cIWpTSoBr2LmHUkQd7JG6zflMffePA+O1eRijnzJ1nALR6PmEp938b7P8/9fFRoKOva gBzbV8uPKUMGxOLv0d6KyzVlNy/IeAfVUwH77iVf5A9YQHWicq6qcYMMOUGxTC/vHJkcEa kv5FajYxM3MWUzS8eR5xulT/J627RTt+f6uaSlaPPjEXmuczvqeCE6cjlAIUYaMjcQ9VE7 CntKF0KeyygjglYIFjNHJ2d1XLJQ0Rzv4wul2n4rQayx5IsTN+vOxRAuQcR9oeAj4DD4Po C3XyZPzl5im+NvzOMVGa6Lwtbb3Ss386xeHcx9yFWIXpClEJPx+WPGqRDEdPnA== Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -1.98 X-Spam-Score: -1.98 X-Migadu-Queue-Id: 4A73913FF5 X-TUID: m5Gg7LBchadC Felipe Contreras writes: > We don't need a FileNames enumerable object only for a small number of strings, > we can just get them directly. > > This iterator is meant to be transient and works only once, so we better just > iterate it once. > > This is the same approach I took with the Tags object, I was waiting for > feedback on that approach but since there isn't any and there's no reason this > shouldn't work, here's the same for Filenames. Hi Felipe; I still haven't had a chance to look at the proposed changes, but I did wonder what your plan was as far as migration. Usually with the library itself we try to provide fairly smooth upgrades. d