From: Michal Sojka <sojkam1@fel.cvut.cz>
To: David Edmondson <dme@dme.org>, David Bremner <david@tethera.net>,
Gregor Hoffleit <gregor@hoffleit.de>,
notmuch <notmuch@notmuchmail.org>
Subject: Re: [PATCH] format_part_json: part_content->data is not null terminated
Date: Thu, 01 Apr 2010 14:05:06 +0200 [thread overview]
Message-ID: <874ojv5qfh.fsf@steelpick.2x.cz> (raw)
In-Reply-To: <87634bjsrl.fsf@ut.hh.sledj.net>
On Thu, 04 Mar 2010, Gregor Hoffleit wrote:
> - printf (", \"content\": %s", json_quote_str (ctx, (char *) part_content->data));
> + content_data = talloc_size (ctx, part_content->len+1);
> + memcpy (content_data, (char *)part_content->data, part_content->len+1);
> + content_data[part_content->len] = 0;
> + printf (", \"content\": %s", json_quote_str (ctx, content_data));
What about modifying json_quote_str() to accept additional parameter
len? If I have 10MB attachment to the email, this unnecessary copy is
quite expensive, isn't it?
--Michal
next prev parent reply other threads:[~2010-04-01 12:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 10:49 [PATCH] format_part_json: part_content->data is not null terminated Gregor Hoffleit
2010-04-01 11:40 ` David Bremner
2010-04-01 11:50 ` David Edmondson
2010-04-01 12:05 ` Michal Sojka [this message]
2010-04-05 9:36 ` David Edmondson
2010-04-05 18:00 ` Carl Worth
2010-04-01 12:05 ` Gregor Hoffleit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ojv5qfh.fsf@steelpick.2x.cz \
--to=sojkam1@fel.cvut.cz \
--cc=david@tethera.net \
--cc=dme@dme.org \
--cc=gregor@hoffleit.de \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).