From: Jesse Rosenthal <jrosenthal@jhu.edu>
To: Dirk Hohndel <hohndel@infradead.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] Add 'd'elete keybinding to search and show views
Date: Wed, 21 Apr 2010 19:25:43 -0400 [thread overview]
Message-ID: <874oj48k20.fsf@jhu.edu> (raw)
In-Reply-To: <1271891763-10757-2-git-send-email-hohndel@infradead.org>
Hi Dirk,
On Wed, 21 Apr 2010 16:16:03 -0700, Dirk Hohndel <hohndel@infradead.org> wrote:
> + (if delete
> + (notmuch-show-add-tag "deleted")))
The one thing I would suggest is adding a level of customizability,
instead of hardcoding in "deleted".
i.e.:
(defvar notmuch-delete-tag "deleted")
and then:
(if delete
(notmuch-show-add-tag notmuch-delete-tag))
The less we force specific tags on users, it seems to me, the better.
Best,
Jesse
next prev parent reply other threads:[~2010-04-21 23:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 23:16 add delete keybinding Dirk Hohndel
2010-04-21 23:16 ` [PATCH] Add 'd'elete keybinding to search and show views Dirk Hohndel
2010-04-21 23:25 ` Jesse Rosenthal [this message]
2010-04-21 23:37 ` Jameson Rollins
2010-04-21 23:55 ` Jesse Rosenthal
2010-04-21 23:32 ` Jameson Rollins
2010-04-22 0:20 ` Dirk Hohndel
2010-04-22 5:06 ` Jameson Rollins
2010-04-23 18:58 ` add delete keybinding Carl Worth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874oj48k20.fsf@jhu.edu \
--to=jrosenthal@jhu.edu \
--cc=hohndel@infradead.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).