From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 5C3A1431FD0 for ; Wed, 1 Jun 2011 22:10:18 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0.01 X-Spam-Level: X-Spam-Status: No, score=0.01 tagged_above=-999 required=5 tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vqxhk2cWlMg2 for ; Wed, 1 Jun 2011 22:10:17 -0700 (PDT) Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2]) by olra.theworths.org (Postfix) with ESMTP id 73485431FB6 for ; Wed, 1 Jun 2011 22:10:17 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 23A8929A4E5; Wed, 1 Jun 2011 22:10:16 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id 090CE54C02C; Wed, 1 Jun 2011 22:10:16 -0700 (PDT) From: Carl Worth To: Jameson Graef Rollins , Notmuch Mail Subject: Re: [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check. In-Reply-To: <1306619520-25730-15-git-send-email-jrollins@finestructure.net> References: <1306619520-25730-1-git-send-email-jrollins@finestructure.net> <1306619520-25730-2-git-send-email-jrollins@finestructure.net> <1306619520-25730-3-git-send-email-jrollins@finestructure.net> <1306619520-25730-4-git-send-email-jrollins@finestructure.net> <1306619520-25730-5-git-send-email-jrollins@finestructure.net> <1306619520-25730-6-git-send-email-jrollins@finestructure.net> <1306619520-25730-7-git-send-email-jrollins@finestructure.net> <1306619520-25730-8-git-send-email-jrollins@finestructure.net> <1306619520-25730-9-git-send-email-jrollins@finestructure.net> <1306619520-25730-10-git-send-email-jrollins@finestructure.net> <1306619520-25730-11-git-send-email-jrollins@finestructure.net> <1306619520-25730-12-git-send-email-jrollins@finestructure.net> <1306619520-25730-13-git-send-email-jrollins@finestructure.net> <1306619520-25730-14-git-send-email-jrollins@finestructure.net> <1306619520-25730-15-git-send-email-jrollins@finestructure.net> User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1 (i486-pc-linux-gnu) Date: Wed, 01 Jun 2011 22:10:07 -0700 Message-ID: <874o48yg28.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jun 2011 05:10:18 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Sat, 28 May 2011 14:51:49 -0700, Jameson Graef Rollins wrote: Hi Jamie, I've pushed the next few patches up to this point, (with only one functional change---I fixed a new test case to correctly use notmuch_search_sanitize to avoid spurious failures unmatching thread ID values). This patch, however, isn't ready. The big problem is in this commit message: > From: Dmitry Kurochkin >=20 > In notmuch 0.5 notmuch-fcc-dirs style changed. The previous code > did not correctly identify an old configuration and, as a > consequence, broke new configurations. There are several things there that are too vague, ("previous code", "old configuration", "new configurations"). What kind of configuration is broken? How does the change here help? It would be easier to understand the code if there were a corresponding test case for it. I'd even be willing to help write a test case, but there are not enough specifics in that commit message to even tell me what to test. > ((and (listp notmuch-fcc-dirs) > - (=3D 1 (length (car notmuch-fcc-dirs)))) > + (stringp (car notmuch-fcc-dirs))) So the "old configuration" was a single string? And this has been inadvertently broken since 0.5? > ;; Old style - no longer works. > (error "Invalid `notmuch-fcc-dirs' setting (old style)")) Yikes. That vague phrasing ("old style") is already in the code in error messages as well. Dmitry, can you help me know what's going on here? (Preferably by sending a newer commit with a more thorough commit message.) Thanks, =2DCarl --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk3nGy8ACgkQ6JDdNq8qSWhjtgCgqoIcakwlAb/jkrpdX/gldWqb uykAn1jqk3hyOh0Vq/Pje1ubAoF84P4S =1ZcD -----END PGP SIGNATURE----- --=-=-=--