From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 10426431FD0 for ; Wed, 20 Jul 2011 11:25:42 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GxQLjZ6C4a1c for ; Wed, 20 Jul 2011 11:25:40 -0700 (PDT) Received: from mail-ew0-f53.google.com (mail-ew0-f53.google.com [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 2F7E3431FB6 for ; Wed, 20 Jul 2011 11:25:40 -0700 (PDT) Received: by ewy8 with SMTP id 8so828320ewy.26 for ; Wed, 20 Jul 2011 11:25:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; bh=epBxgWP1rdT/8D7IQuMxmEAL5DOwwWuyKpip6n508mE=; b=WKBbqeOPOukRo7pNrngBtFw3DTUbECwltNzsphagkBOwH0HFUr1Ib/A6qZT6svUKrv o0p41+Wfq6KACtkuL++YOFrDlt4+2LaqDhLbSCd2FalagHbUXiVMDidSKqQpgxYhwr8+ i004ZDYrWvFZXlja+0xVNCQLSiuEGe2Y+5gWE= Received: by 10.14.27.200 with SMTP id e48mr3411613eea.125.1311186338624; Wed, 20 Jul 2011 11:25:38 -0700 (PDT) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id e48sm691402eeb.37.2011.07.20.11.25.36 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 20 Jul 2011 11:25:37 -0700 (PDT) From: Dmitry Kurochkin To: Thomas Jost , Jameson Graef Rollins , notmuch@notmuchmail.org Subject: Re: [PATCH] test: run emacs inside tmux if screen is not available In-Reply-To: <8762mw7rdk.fsf@schnouki.net> References: <1309496122-4965-2-git-send-email-dmitry.kurochkin@gmail.com> <1311165396-12268-1-git-send-email-schnouki@schnouki.net> <87d3h5ul7k.fsf@gmail.com> <87k4bc275l.fsf@servo.factory.finestructure.net> <8762mw7rdk.fsf@schnouki.net> User-Agent: Notmuch/0.5-321-g41686e2 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Wed, 20 Jul 2011 22:25:33 +0400 Message-ID: <874o2germq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2011 18:25:42 -0000 On Wed, 20 Jul 2011 20:12:55 +0200, Thomas Jost wrote: > On Wed, 20 Jul 2011 10:28:38 -0700, Jameson Graef Rollins wrote: > Non-text part: multipart/signed > > On Wed, 20 Jul 2011 17:37:35 +0400, Dmitry Kurochkin wrote: > > > On Wed, 20 Jul 2011 14:36:36 +0200, Thomas Jost wrote: > > > > Before this change, the test suite reported many failed tests on machines where > > > > screen is not installed (which is the case of many *BSD systems). This patch > > > > makes the test suite try to use tmux, another terminal multiplexer, if screen is > > > > not available. > > > > > > This is a nice improvement. But I think we should make it even better :) > > > There are more terminal emulators besides screen and tmux (dtach comes > > > to mind). We need a more general mechanism for trying them. There > > > should be a list of commands for running terminal emulators in the order > > > of preference (I think that is dtach, tmux, screen), and we should try > > > each one in a loop (this would also avoid repeating the long emacs > > > command). > > > > Hi, guys. I suppose you can go down this route if you want, but I worry > > that it just adds a lot of extra code to the test suite that will > > ultimately make it less robust. What's wrong with just depending on > > screen for the tests? I'm sure screen is available on every operating > > system that we currently support. > > > > It makes me wary that we would be starting a precedent for making a > > bunch of conditionals for all of the possible alternative tools we use > > in the test suite. Maybe that's an overblown concern, though. > > > > jamie. > > You're right, just depending on screen would be enough (the package is > just 864 kB on Arch Linux...), and supporting alternative tools > would make the test suite more complicated and less robust. But the > dependency on screen should be more *explicit*: if it's not available, > the test suite should skip all the emacs tests and display a message > about screen. > > Apparently test-lib.sh includes some things about prerequisites. I'll > try to use these to implement the explicit dependency on screen. > Full ack. The only reason I did not implement it in the original patch is because there is an existing patch series [1] that adds proper prerequisites for gdb, emacs and gpg. So instead of reimplementing the same thing, I decided to wait until that series is merged and add screen prerequisite later. Regards, Dmitry [1] id:"1307016220-17509-1-git-send-email-pieter@praet.org" > Regards, > > -- > Thomas/Schnouki Non-text part: application/pgp-signature