From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Thomas Jost <schnouki@schnouki.net>,
Jameson Graef Rollins <jrollins@finestructure.net>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] test: run emacs inside tmux if screen is not available
Date: Wed, 20 Jul 2011 22:25:33 +0400 [thread overview]
Message-ID: <874o2germq.fsf@gmail.com> (raw)
In-Reply-To: <8762mw7rdk.fsf@schnouki.net>
On Wed, 20 Jul 2011 20:12:55 +0200, Thomas Jost <schnouki@schnouki.net> wrote:
> On Wed, 20 Jul 2011 10:28:38 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> Non-text part: multipart/signed
> > On Wed, 20 Jul 2011 17:37:35 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > > On Wed, 20 Jul 2011 14:36:36 +0200, Thomas Jost <schnouki@schnouki.net> wrote:
> > > > Before this change, the test suite reported many failed tests on machines where
> > > > screen is not installed (which is the case of many *BSD systems). This patch
> > > > makes the test suite try to use tmux, another terminal multiplexer, if screen is
> > > > not available.
> > >
> > > This is a nice improvement. But I think we should make it even better :)
> > > There are more terminal emulators besides screen and tmux (dtach comes
> > > to mind). We need a more general mechanism for trying them. There
> > > should be a list of commands for running terminal emulators in the order
> > > of preference (I think that is dtach, tmux, screen), and we should try
> > > each one in a loop (this would also avoid repeating the long emacs
> > > command).
> >
> > Hi, guys. I suppose you can go down this route if you want, but I worry
> > that it just adds a lot of extra code to the test suite that will
> > ultimately make it less robust. What's wrong with just depending on
> > screen for the tests? I'm sure screen is available on every operating
> > system that we currently support.
> >
> > It makes me wary that we would be starting a precedent for making a
> > bunch of conditionals for all of the possible alternative tools we use
> > in the test suite. Maybe that's an overblown concern, though.
> >
> > jamie.
>
> You're right, just depending on screen would be enough (the package is
> just 864 kB on Arch Linux...), and supporting alternative tools
> would make the test suite more complicated and less robust. But the
> dependency on screen should be more *explicit*: if it's not available,
> the test suite should skip all the emacs tests and display a message
> about screen.
>
> Apparently test-lib.sh includes some things about prerequisites. I'll
> try to use these to implement the explicit dependency on screen.
>
Full ack. The only reason I did not implement it in the original patch
is because there is an existing patch series [1] that adds proper
prerequisites for gdb, emacs and gpg. So instead of reimplementing the
same thing, I decided to wait until that series is merged and add screen
prerequisite later.
Regards,
Dmitry
[1] id:"1307016220-17509-1-git-send-email-pieter@praet.org"
> Regards,
>
> --
> Thomas/Schnouki
Non-text part: application/pgp-signature
next prev parent reply other threads:[~2011-07-20 18:25 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 19:42 [PATCH 1/6] test: run emacs inside screen Dmitry Kurochkin
2011-06-29 19:42 ` [PATCH 2/6] test: do not set frame width in emacs Dmitry Kurochkin
2011-06-29 19:42 ` [PATCH 3/6] test: `notmuch-show-advance-and-archive' with invisible signature Dmitry Kurochkin
2011-06-29 19:42 ` [PATCH 4/6] emacs: improve hidden signatures handling in notmuch-show-advance-and-archive Dmitry Kurochkin
2011-06-29 19:42 ` [PATCH 5/6] emacs: remove no longer used functions from notmuch-show.el Dmitry Kurochkin
2011-06-29 19:42 ` [PATCH 6/6] emacs: remove unused `point-invisible-p' function Dmitry Kurochkin
2011-06-29 20:16 ` [PATCH 1/6] test: run emacs inside screen Jim Paris
2011-06-29 21:27 ` Dmitry Kurochkin
2011-06-29 21:26 ` [PATCH] test: avoid using screen(1) configuration files Dmitry Kurochkin
2011-07-01 4:55 ` [PATCH v2 0/7] advance-and-archive bugfix, run emacs inside screen Dmitry Kurochkin
2011-07-01 4:55 ` [PATCH v2 1/7] test: " Dmitry Kurochkin
2011-07-20 12:36 ` [PATCH] test: run emacs inside tmux if screen is not available Thomas Jost
2011-07-20 13:37 ` Dmitry Kurochkin
2011-07-20 17:28 ` Jameson Graef Rollins
2011-07-20 18:12 ` Thomas Jost
2011-07-20 18:25 ` Dmitry Kurochkin [this message]
2011-07-01 4:55 ` [PATCH v2 2/7] test: avoid using screen(1) configuration files Dmitry Kurochkin
2011-07-01 4:55 ` [PATCH v2 3/7] test: do not set frame width in emacs Dmitry Kurochkin
2011-07-01 4:55 ` [PATCH v2 4/7] test: `notmuch-show-advance-and-archive' with invisible signature Dmitry Kurochkin
2011-11-06 1:06 ` David Bremner
2011-11-06 9:02 ` Dmitry Kurochkin
2011-11-06 9:03 ` [PATCH v3 1/4] " Dmitry Kurochkin
2011-11-06 9:03 ` [PATCH v3 2/4] emacs: improve hidden signatures handling in notmuch-show-advance-and-archive Dmitry Kurochkin
2011-11-06 9:04 ` [PATCH v3 3/4] emacs: remove no longer used functions from notmuch-show.el Dmitry Kurochkin
2011-11-06 9:04 ` [PATCH v3 4/4] emacs: remove unused `point-invisible-p' function Dmitry Kurochkin
2011-11-08 0:50 ` [PATCH v2 4/7] test: `notmuch-show-advance-and-archive' with invisible signature David Bremner
2011-07-01 4:55 ` [PATCH v2 5/7] emacs: improve hidden signatures handling in notmuch-show-advance-and-archive Dmitry Kurochkin
2011-09-07 9:13 ` Jani Nikula
2011-09-07 11:09 ` Dmitry Kurochkin
2011-07-01 4:55 ` [PATCH v2 6/7] emacs: remove no longer used functions from notmuch-show.el Dmitry Kurochkin
2011-07-01 4:55 ` [PATCH v2 7/7] emacs: remove unused `point-invisible-p' function Dmitry Kurochkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874o2germq.fsf@gmail.com \
--to=dmitry.kurochkin@gmail.com \
--cc=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
--cc=schnouki@schnouki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).