From: Pieter Praet <pieter@praet.org>
To: David Bremner <david@tethera.net>,
Thomas Jost <schnouki@schnouki.net>,
notmuch@notmuchmail.org
Subject: Re: [PATCH 00/13] Test prereqs and screen-based Emacs tests
Date: Wed, 16 Nov 2011 14:03:04 +0100 [thread overview]
Message-ID: <874ny4fcdz.fsf@praet.org> (raw)
In-Reply-To: <871utb6hl5.fsf@zancas.localnet>
On Sun, 13 Nov 2011 13:46:30 -0400, David Bremner <david@tethera.net> wrote:
> On Tue, 01 Nov 2011 20:54:49 +0100, Pieter Praet <pieter@praet.org> wrote:
> >
> > I'll be commenting on these modified commits where needed, and have
> > re-submitted my original series (rebased to current master) in a new
> > thread [1].
> >
>
> I'm having trouble sorting out which of these series should be
> considered for notmuch master. Is there something in the rebased version
> of Pieter's patches that is not present in Thomas's rebased version?
>
Nope, I simply rebased my original series, warts and all.
Thomas' submission contains a number of fixes (missing prereqs) and
improvements (test_set_bin_prereq) that should definitely be included
before the series is applied, as well as some stuff that belongs in
separate commits (e.g. screen prereq, which should now check for dtach
instead) and a tiny mistake in the "Reply within emacs" subtest [1].
Also, both Jameson [2] and Ali [3] have brought up some valid
points/concerns re the way we find and set prereqs.
Thomas, could you please rebase your fixes on top of my rebased series,
and submit them in the new thread [4] ? The whole deal could then be
applied on a feature branch and merged into mainline integrally.
> d
Peace
--
Pieter
[1] id:"87fwi7obso.fsf@praet.org"
[2] id:"87hb2n4k5c.fsf@servo.finestructure.net"
[3] id:"20111101202025.GA8248@hayalet"
[4] id:"1320176954-4897-1-git-send-email-pieter@praet.org"
next prev parent reply other threads:[~2011-11-16 13:04 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 1:59 [PATCH 1/3] test: update documentation for test_emacs in test/README Dmitry Kurochkin
2011-07-04 1:59 ` [PATCH 2/3] test: improve known broken tests support Dmitry Kurochkin
2011-07-04 3:42 ` Austin Clements
2011-07-04 3:46 ` Dmitry Kurochkin
2011-07-04 1:59 ` [PATCH 3/3] test: add emacs test for hiding a message following an HTML part Dmitry Kurochkin
2011-09-26 11:01 ` David Bremner
2011-09-26 17:25 ` Dmitry Kurochkin
2011-10-01 11:51 ` David Bremner
2011-10-02 1:45 ` Dmitry Kurochkin
2011-10-03 12:39 ` Thomas Jost
2011-10-03 13:38 ` Dmitry Kurochkin
2011-10-03 14:27 ` David Bremner
2011-10-03 16:47 ` [PATCH 00/13] Test prereqs and screen-based Emacs tests Thomas Jost
2011-11-01 19:54 ` Pieter Praet
2011-11-13 17:46 ` David Bremner
2011-11-16 13:03 ` Pieter Praet [this message]
2011-10-03 16:47 ` [PATCH 01/13] test: define a helper function for defining prereqs on executables Thomas Jost
2011-10-03 16:47 ` [PATCH 02/13] test: add 'GnuPG' prereq to dependent 'crypto' tests Thomas Jost
2011-10-03 16:47 ` [PATCH 03/13] test: add 'Emacs' " Thomas Jost
2011-11-01 19:56 ` Pieter Praet
2011-11-01 20:15 ` Pieter Praet
2011-10-03 16:47 ` [PATCH 04/13] test: add 'Emacs' prereq to dependent 'emacs' tests Thomas Jost
2011-11-01 19:57 ` Pieter Praet
2011-11-01 20:08 ` Pieter Praet
2011-10-03 16:47 ` [PATCH 05/13] test: add 'Emacs' prereq to dependent 'emacs-large-search-buffer' tests Thomas Jost
2011-10-03 16:47 ` [PATCH 06/13] test: run emacs inside screen Thomas Jost
2011-11-10 7:36 ` Jameson Graef Rollins
2011-11-10 8:10 ` Thomas Jost
2011-10-03 16:47 ` [PATCH 07/13] test: avoid using screen(1) configuration files Thomas Jost
2011-10-03 16:47 ` [PATCH 08/13] test: do not set frame width in emacs Thomas Jost
2011-10-03 16:47 ` [PATCH 09/13] test: `notmuch-show-advance-and-archive' with invisible signature Thomas Jost
2011-10-03 16:47 ` [PATCH 10/13] emacs: improve hidden signatures handling in notmuch-show-advance-and-archive Thomas Jost
2011-10-03 16:47 ` [PATCH 11/13] emacs: remove no longer used functions from notmuch-show.el Thomas Jost
2011-10-03 16:47 ` [PATCH 12/13] emacs: remove unused `point-invisible-p' function Thomas Jost
2011-10-03 16:47 ` [PATCH 13/13] test: make smtp-dummy work with Emacs 24 Thomas Jost
2011-11-13 19:09 ` David Bremner
2011-12-15 12:14 ` [PATCH 3/3] test: add emacs test for hiding a message following an HTML part David Bremner
2011-12-15 17:27 ` Tom Prince
2011-12-16 18:51 ` Dmitry Kurochkin
2011-07-04 4:07 ` [PATCH v2 0/3] improved broken tests support and test for a bug Dmitry Kurochkin
2011-07-04 4:07 ` [PATCH v2 1/3] test: update documentation for test_emacs in test/README Dmitry Kurochkin
2011-07-04 4:07 ` [PATCH v2 2/3] test: improve known broken tests support Dmitry Kurochkin
2011-09-11 23:11 ` [PATCH] test: reset known_broken status in test_expect_equal and test_expect_equal_file david
2011-09-11 23:30 ` Dmitry Kurochkin
2011-09-11 23:51 ` David Bremner
2011-09-12 0:26 ` Dmitry Kurochkin
2011-09-13 2:41 ` [PATCH] test: reset test_subtest_known_broken_ after each success/failure david
2011-09-13 10:19 ` Dmitry Kurochkin
2011-09-13 11:39 ` David Bremner
2011-07-04 4:07 ` [PATCH v2 3/3] test: add emacs test for hiding a message following an HTML part Dmitry Kurochkin
2011-09-10 18:08 ` [PATCH v2 0/3] improved broken tests support and test for a bug David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ny4fcdz.fsf@praet.org \
--to=pieter@praet.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=schnouki@schnouki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).