From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 9E525429E28 for ; Fri, 16 Dec 2011 10:51:47 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xh1a+gylJj+h for ; Fri, 16 Dec 2011 10:51:47 -0800 (PST) Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id DA6A2429E26 for ; Fri, 16 Dec 2011 10:51:46 -0800 (PST) Received: by werm12 with SMTP id m12so744746wer.26 for ; Fri, 16 Dec 2011 10:51:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; bh=raz0+VWXEb2G3oObBO6eCFoqbk7vqbTrIRypsJKlq7c=; b=cLNcKIhXYUV6WZ3PhYDVzDXCVOyxCuM3jTgkc8WCmD/4P1ouj/UMtIugxaPbT65CWz D55GwIuyrw7K0katkhdpnsSUugPihEKlcQonn0oF+wPkhSFT/FH3Zm+O7JAnLZlLZ2/4 isLIBD4f4Rvp2so84AQn8mXGyba52LO48uZvE= Received: by 10.216.139.197 with SMTP id c47mr3603290wej.23.1324061505744; Fri, 16 Dec 2011 10:51:45 -0800 (PST) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id fg15sm15593899wbb.7.2011.12.16.10.51.44 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 16 Dec 2011 10:51:45 -0800 (PST) From: Dmitry Kurochkin To: Tom Prince , David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH 3/3] test: add emacs test for hiding a message following an HTML part In-Reply-To: <87ehw5lp8a.fsf@loki.hocat.ca> References: <1309744743-8556-1-git-send-email-dmitry.kurochkin@gmail.com> <1309744743-8556-3-git-send-email-dmitry.kurochkin@gmail.com> <87vcpiyqun.fsf@zancas.localnet> <87ehw5lp8a.fsf@loki.hocat.ca> User-Agent: Notmuch/0.10.2+96~g74e5ae5 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Fri, 16 Dec 2011 22:51:05 +0400 Message-ID: <874nx0s63q.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Dec 2011 18:51:47 -0000 Hi Tom. On Thu, 15 Dec 2011 10:27:33 -0700, Tom Prince wrote: > On Thu, 15 Dec 2011 08:14:08 -0400, David Bremner wrote: > > On Mon, 4 Jul 2011 05:59:03 +0400, Dmitry Kurochkin wrote: > > > Result: nothing happens except for "No URL at point" message > > > > > > Expected result: the second message is shown/hidden > > > > Unfortunately this patch is unreliable, reporting BROKEN for some > > environments and FIXED for others; I think you mentioned it depends > > on whether w3m-el is installed? I have reverted it for now to reduce the > > noise in the test logs. > > Would a proper fix for this be to explicitly select which html renderer > is used, and then test it with each renderer in turn? If it is the > renderer that is causing the BROKEN/FIXED distinction, this would > trigger all possbile behaviors. > I know that the issue affects w3m-el renderer and does not affect w3m-standalone. Though it may affect other renderers as well. So we could explicitly set the renderer to w3m-el for the test. But we need to make sure we skip the test if w3m-el is not available. The bug itself is related to keymap property that is set for the rendered HTML. It is set for the final newline as well. And it is rear-sticky. I am not sure about how to better fix this. I do not plan to work on this issue in the near future, so I do not want to spend time on fixing this test case now. If you feel like working on it, you are welcome. Regards, Dmitry > Tom