From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bremner@unb.ca>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 17498429E3B
	for <notmuch@notmuchmail.org>; Mon, 16 Jan 2012 14:21:29 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -2.3
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
	tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id m8QX+Ro+t67s for <notmuch@notmuchmail.org>;
	Mon, 16 Jan 2012 14:21:28 -0800 (PST)
Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 6AFF5429E35
	for <notmuch@notmuchmail.org>; Mon, 16 Jan 2012 14:21:28 -0800 (PST)
Received: from zancas.localnet
	(fctnnbsc36w-156034071197.pppoe-dynamic.High-Speed.nb.bellaliant.net
	[156.34.71.197]) (authenticated bits=0)
	by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id q0GMLOsu017688
	(version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO);
	Mon, 16 Jan 2012 18:21:25 -0400
Received: from bremner by zancas.localnet with local (Exim 4.77)
	(envelope-from <bremner@unb.ca>)
	id 1Rmuvc-000130-Et; Mon, 16 Jan 2012 18:21:24 -0400
From: David Bremner <david@tethera.net>
To: Aaron Ecay <aaronecay@gmail.com>, David Edmondson <dme@dme.org>,
	Pieter Praet <pieter@praet.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Don't attempt to colour tags in
 `notmuch-show-mode'.
In-Reply-To: <m2zkdnbcbx.fsf@gmail.com>
References: <1325004434-24583-1-git-send-email-dme@dme.org>
	<87aa5nlwwg.fsf@praet.org>
	<cunmx9n51u4.fsf@hotblack-desiato.hh.sledj.net>
	<m2zkdnbcbx.fsf@gmail.com>
User-Agent: Notmuch/0.11+61~gbaa2c97 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Mon, 16 Jan 2012 18:21:24 -0400
Message-ID: <874nvvi90b.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Jan 2012 22:21:29 -0000

On Mon, 16 Jan 2012 15:51:30 -0500, Aaron Ecay <aaronecay@gmail.com> wrote:
> On Mon, 16 Jan 2012 11:22:27 +0000, David Edmondson <dme@dme.org> wrote:
> > On Mon, 16 Jan 2012 12:17:03 +0100, Pieter Praet <pieter@praet.org> wro=
te:
> > > Alas, those text properties actually *were* effective (and I liked th=
em :)
> >=20
> > Well, not in emacs 24. My reading of the source was that overlays were
> > intended to stomp on text properties, but that could have been wrong.
> >=20
> > Do they look correct when you add/remove tags?
>=20
> The tags look nice and yellow-green for me too on a trunk build of emacs
> (which is one flavor of emacs 24).  Adding and removing tags works as
> expected =E2=80=93 the tags dis/appear and are the right color.
>=20
> I haven=E2=80=99t reloaded the notmuch *.el files since this change lande=
d, but
> I agree with Pieter that the overlays were nice.

I'm leaning to revert this patch. Any opposition?

d