From: David Bremner <david@tethera.net>
To: Aaron Ecay <aaronecay@gmail.com>, David Edmondson <dme@dme.org>,
Pieter Praet <pieter@praet.org>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.
Date: Mon, 16 Jan 2012 18:21:24 -0400 [thread overview]
Message-ID: <874nvvi90b.fsf@zancas.localnet> (raw)
In-Reply-To: <m2zkdnbcbx.fsf@gmail.com>
On Mon, 16 Jan 2012 15:51:30 -0500, Aaron Ecay <aaronecay@gmail.com> wrote:
> On Mon, 16 Jan 2012 11:22:27 +0000, David Edmondson <dme@dme.org> wrote:
> > On Mon, 16 Jan 2012 12:17:03 +0100, Pieter Praet <pieter@praet.org> wrote:
> > > Alas, those text properties actually *were* effective (and I liked them :)
> >
> > Well, not in emacs 24. My reading of the source was that overlays were
> > intended to stomp on text properties, but that could have been wrong.
> >
> > Do they look correct when you add/remove tags?
>
> The tags look nice and yellow-green for me too on a trunk build of emacs
> (which is one flavor of emacs 24). Adding and removing tags works as
> expected – the tags dis/appear and are the right color.
>
> I haven’t reloaded the notmuch *.el files since this change landed, but
> I agree with Pieter that the overlays were nice.
I'm leaning to revert this patch. Any opposition?
d
next prev parent reply other threads:[~2012-01-16 22:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-27 16:47 [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode' David Edmondson
2011-12-28 3:29 ` Austin Clements
2011-12-28 12:42 ` Xavier Maillard
2011-12-28 20:09 ` Jameson Graef Rollins
2011-12-28 21:51 ` Xavier Maillard
2011-12-28 12:43 ` Xavier Maillard
2012-01-16 3:03 ` David Bremner
2012-01-16 11:17 ` Pieter Praet
2012-01-16 11:22 ` David Edmondson
2012-01-16 11:44 ` Pieter Praet
2012-01-16 20:51 ` Aaron Ecay
2012-01-16 21:24 ` Jani Nikula
2012-01-16 22:21 ` David Bremner [this message]
2012-01-17 7:22 ` David Edmondson
2012-01-17 12:05 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nvvi90b.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=aaronecay@gmail.com \
--cc=dme@dme.org \
--cc=notmuch@notmuchmail.org \
--cc=pieter@praet.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).