From: Mark Walters <markwalters1009@gmail.com>
To: Adam Wolfe Gordon <awg+notmuch@xvx.ca>, notmuch@notmuchmail.org
Subject: Re: [PATCH v3 4/5] emacs: Use the new JSON reply format.
Date: Sun, 05 Feb 2012 12:41:40 +0000 [thread overview]
Message-ID: <874nv5wiyj.fsf@qmul.ac.uk> (raw)
In-Reply-To: <1326995217-27423-5-git-send-email-awg+notmuch@xvx.ca>
On Thu, 19 Jan 2012 10:46:56 -0700, Adam Wolfe Gordon <awg+notmuch@xvx.ca> wrote:
> Using the new JSON reply format allows emacs to quote HTML
> parts nicely by using mm-display-part to turn them into displayable
> text, then quoting them. This is very useful for users who
> regularly receive HTML-only email.
>
> The behavior for messages that contain plain text parts should be
> unchanged.
Hi I have tried using this patch and it did give an identical emacs
buffer when replying to text/plain or multipart/alternative messages
except for two things:
the old one put a line in the reply for each attachment not being
included in the reply (eg "Attachment: file.pdf (application/pdf)" ) and
the new one does not.
and your version does not include text/plain attachments with
disposition attachment (obviously as the cli part does not).
[Note I am not saying whether either of these correct or not, just that
they are changes.]
It also worked nicely on the html only messages I tried it on.
I have not reviewed the lisp yet; I will try and have a look at it but I
am a lisp beginner.
Best wishes
Mark
PS Sorry I sent this from my unsubscribed address first: since I am
using your patch-set my recent reply From: modification wasn't there!
next prev parent reply other threads:[~2012-02-05 12:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 17:46 [PATCH v3 0/5] Quoting HTML emails in reply Adam Wolfe Gordon
2012-01-19 17:46 ` [PATCH v3 1/5] test: Add broken test for the new JSON reply format Adam Wolfe Gordon
2012-01-19 17:46 ` [PATCH v3 2/5] reply: Add a " Adam Wolfe Gordon
2012-02-05 11:50 ` Mark Walters
2012-02-05 12:45 ` Mark Walters
2012-02-05 19:42 ` Adam Wolfe Gordon
2012-02-05 19:50 ` Dmitry Kurochkin
2012-02-06 3:44 ` Austin Clements
2012-02-06 6:27 ` Adam Wolfe Gordon
2012-01-19 17:46 ` [PATCH v3 3/5] man: Update notmuch-reply man page for JSON format Adam Wolfe Gordon
2012-01-19 17:46 ` [PATCH v3 4/5] emacs: Use the new JSON reply format Adam Wolfe Gordon
2012-02-05 12:41 ` Mark Walters [this message]
2012-01-19 17:46 ` [PATCH v3 5/5] emacs: Use message-citation-line-format in reply Adam Wolfe Gordon
2012-01-19 18:45 ` Aaron Ecay
2012-01-20 4:46 ` Adam Wolfe Gordon
2012-01-20 5:53 ` Aaron Ecay
2012-01-20 9:14 ` David Edmondson
2012-01-20 17:22 ` Adam Wolfe Gordon
2012-01-20 22:31 ` Tomi Ollila
2012-01-22 18:58 ` [PATCH v3 5/5] emacs: Use message-cite-original " Adam Wolfe Gordon
2012-02-09 0:21 ` [PATCH v4 0/4] Quoting HTML parts in reply (and other reply enhancements) Adam Wolfe Gordon
2012-02-09 0:21 ` [PATCH v4 1/4] test: Add broken test for the new JSON reply format Adam Wolfe Gordon
2012-02-09 0:21 ` [PATCH v4 2/4] reply: Add a " Adam Wolfe Gordon
2012-02-09 7:22 ` Dmitry Kurochkin
2012-02-10 4:27 ` Adam Wolfe Gordon
2012-02-10 8:39 ` Dmitry Kurochkin
2012-02-09 0:21 ` [PATCH v4 3/4] man: Update notmuch-reply man page for JSON format Adam Wolfe Gordon
2012-02-09 0:21 ` [PATCH v4 4/4] emacs: Use the new JSON reply format and message-cite-original Adam Wolfe Gordon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nv5wiyj.fsf@qmul.ac.uk \
--to=markwalters1009@gmail.com \
--cc=awg+notmuch@xvx.ca \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).