unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] NEWS: document that print message prints all parts including hidden parts
@ 2013-01-17  0:44 Mark Walters
  2013-01-17  1:49 ` Tomi Ollila
  2013-01-19 12:58 ` David Bremner
  0 siblings, 2 replies; 3+ messages in thread
From: Mark Walters @ 2013-01-17  0:44 UTC (permalink / raw)
  To: notmuch

---
The new invisibility code means that notmuch-show-print-message prints
all parts of the message regardless of whether they are shown or
hidden. This is probably a bug but the correct fix, and even the
`correct' behaviour is not clear. So for the moment just document the
current behaviour.

Note the default setup before would also have printed all parts since 
notmuch-show-all-multipart/alternative-parts defaulted true.

Best wishes

Mark

 NEWS |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/NEWS b/NEWS
index 69f21a0..f16381c 100644
--- a/NEWS
+++ b/NEWS
@@ -81,6 +81,10 @@ Visibility of MIME parts can be toggled
   `notmuch-multipart/alternative-discouraged` and
   `notmuch-show-all-multipart/alternative-parts`.
 
+  Note notmuch-show-print-message (bound to '#' by default) will print
+  all parts of multipart/alternative message regardless of whether
+  they are currently hidden or shown in the buffer.
+
 Emacs now buttonizes mid: links
 
   mid: links are a standardized way to link to messages by message ID
-- 
1.7.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] NEWS: document that print message prints all parts including hidden parts
  2013-01-17  0:44 [PATCH] NEWS: document that print message prints all parts including hidden parts Mark Walters
@ 2013-01-17  1:49 ` Tomi Ollila
  2013-01-19 12:58 ` David Bremner
  1 sibling, 0 replies; 3+ messages in thread
From: Tomi Ollila @ 2013-01-17  1:49 UTC (permalink / raw)
  To: Mark Walters, notmuch

On Thu, Jan 17 2013, Mark Walters <markwalters1009@gmail.com> wrote:

> ---

How did you manage to get this part under the --- -separator;
I think this part below will not go to the commit message.

Otherwise, NEWS entry looks good to me. The same thing happens
when one `copy-region-as-kill`s region -- when yanking the invisible
part appears. This is easily noticiable by user and therefore I suggest
no effort is taken to document it -- someone might even think it
lessens the S/N ratio (due to tl;dr effect).

Tomi


> The new invisibility code means that notmuch-show-print-message prints
> all parts of the message regardless of whether they are shown or
> hidden. This is probably a bug but the correct fix, and even the
> `correct' behaviour is not clear. So for the moment just document the
> current behaviour.
>
> Note the default setup before would also have printed all parts since 
> notmuch-show-all-multipart/alternative-parts defaulted true.
>
> Best wishes
>
> Mark
>
>  NEWS |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/NEWS b/NEWS
> index 69f21a0..f16381c 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -81,6 +81,10 @@ Visibility of MIME parts can be toggled
>    `notmuch-multipart/alternative-discouraged` and
>    `notmuch-show-all-multipart/alternative-parts`.
>  
> +  Note notmuch-show-print-message (bound to '#' by default) will print
> +  all parts of multipart/alternative message regardless of whether
> +  they are currently hidden or shown in the buffer.
> +
>  Emacs now buttonizes mid: links
>  
>    mid: links are a standardized way to link to messages by message ID
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] NEWS: document that print message prints all parts including hidden parts
  2013-01-17  0:44 [PATCH] NEWS: document that print message prints all parts including hidden parts Mark Walters
  2013-01-17  1:49 ` Tomi Ollila
@ 2013-01-19 12:58 ` David Bremner
  1 sibling, 0 replies; 3+ messages in thread
From: David Bremner @ 2013-01-19 12:58 UTC (permalink / raw)
  To: Mark Walters, notmuch

Mark Walters <markwalters1009@gmail.com> writes:

> ---
> The new invisibility code means that notmuch-show-print-message prints
> all parts of the message regardless of whether they are shown or
> hidden. This is probably a bug but the correct fix, and even the
> `correct' behaviour is not clear. So for the moment just document the
> current behaviour.

Pushed as part of the release. 

I think that one line commit messages are probably defensible when the
only change is adding NEWS.

d

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-01-19 12:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-17  0:44 [PATCH] NEWS: document that print message prints all parts including hidden parts Mark Walters
2013-01-17  1:49 ` Tomi Ollila
2013-01-19 12:58 ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).