unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>,
	Tomi Ollila <tomi.ollila@iki.fi>,
	notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: Re: [PATCH 1/2] emacs: defconst notmuch-emacs-version to a value during byte compilation
Date: Thu, 23 Jan 2014 19:45:24 -0400	[thread overview]
Message-ID: <874n4uqn3f.fsf@zancas.localnet> (raw)
In-Reply-To: <8738kezhwe.fsf@qmul.ac.uk>

Mark Walters <markwalters1009@gmail.com> writes:

> If I make and then commit a small change to emacs/notmuch-tree.el and then
> remake then version string in the cli nor in emacs seems to be
> updated. If I make clean and then make it is updated.

I think I understand why this is happening: notmuch-lib.el is not
recompiled if it isn't modified. I'm not sure of the best fix, but I
guess the dependencies in emacs/.eldeps need to be updated.  One option
would be to have a seperate notmuch-version.el that depends on
everything.

d

      reply	other threads:[~2014-01-23 23:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-19 12:51 [PATCH 1/2] emacs: defconst notmuch-emacs-version to a value during byte compilation Tomi Ollila
2014-01-19 12:51 ` [PATCH 2/2] emacs: defun notmuch-hello-versions and bind 'v' in hello mode to it Tomi Ollila
2014-01-23 18:12 ` [PATCH 1/2] emacs: defconst notmuch-emacs-version to a value during byte compilation Mark Walters
2014-01-23 23:45   ` David Bremner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874n4uqn3f.fsf@zancas.localnet \
    --to=david@tethera.net \
    --cc=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    --cc=tomi.ollila@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).