From: David Bremner <david@tethera.net>
To: Ludovic LANGE <ll-notmuchmail@lange.nom.fr>, notmuch@notmuchmail.org
Subject: Re: [PATCH] ruby: add bindings for `notmuch_database_get_all_tags`
Date: Wed, 31 Dec 2014 21:11:06 +0100 [thread overview]
Message-ID: <874msbh95x.fsf@maritornes.cs.unb.ca> (raw)
In-Reply-To: <1416167892-15686-1-git-send-email-ll-notmuchmail@lange.nom.fr>
Ludovic LANGE <ll-notmuchmail@lange.nom.fr> writes:
> + tags = notmuch_database_get_all_tags (db);
> + if (!tags)
> + rb_raise (notmuch_rb_eMemoryError, "Out of memory");
Hi Ludovic;
Sorry about the slow response. It's not really your fault, but this
exception is is not really correct, since there are at least two
possible error conditions which get squashed into a NULL. I have
proposed a series [1] which should make it possible to tell the
difference, but in the mean time I wonder if it would be better to
to do
rb_raise (notmuch_rb_eBaseError, "unknown notmuch error")
with a comment "XXX: figure out actual error".
Cheers,
d
[1]: id:1419788030-10567-2-git-send-email-david@tethera.net
next prev parent reply other threads:[~2014-12-31 20:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-16 19:58 [PATCH] ruby: add bindings for `notmuch_database_get_all_tags` Ludovic LANGE
2014-12-31 20:11 ` David Bremner [this message]
2016-03-06 11:56 ` David Bremner
2016-05-19 11:07 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874msbh95x.fsf@maritornes.cs.unb.ca \
--to=david@tethera.net \
--cc=ll-notmuchmail@lange.nom.fr \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).