From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: fix for dump headers
Date: Sat, 01 Apr 2017 09:41:20 -0300 [thread overview]
Message-ID: <874ly8gv0v.fsf@tethera.net> (raw)
In-Reply-To: <m2pogw4c0d.fsf@guru.guru-group.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
> On Tue, Mar 28 2017, David Bremner <david@tethera.net> wrote:
>
>> When I added message properties to the dump output I messed up the
>> copy-paste to add properties to the header. The fix is trivial, but
>> I'm not sure if this means we should bump the format version
>> (i.e. write #notmuch-dump:3) to denote the header can be relied
>> upon. I guess it doesn't hurt to do so. Opinions?
>
> I'd say bump the format version... so rest of the series LGTM.
>
> Tomi
OK, pushed to master and release
d
prev parent reply other threads:[~2017-04-01 12:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 11:09 fix for dump headers David Bremner
2017-03-28 11:09 ` [PATCH 1/2] test: add known broken test for dump header David Bremner
2017-04-01 0:23 ` David Bremner
2017-03-28 11:09 ` [PATCH 2/2] cli/dump: fix bug in " David Bremner
2017-03-31 10:55 ` [PATCH] cli/dump: bump dump format version to 3 David Bremner
2017-04-01 11:12 ` fix for dump headers Tomi Ollila
2017-04-01 12:41 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ly8gv0v.fsf@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).