Re: notmuch-emacs and Emacs26 (master)

[David Bremner <david@tethera.net>]

[-- Attachment #1: Type: text/plain, Size: 1330 bytes --]

Thomas Hisch <t.hisch@gmail.com> writes:

> I fixed this by applying the following patch. TBH, I didn't check that
> everything is still working as expected, but the compilation succeeds.
>
> ---
>  emacs/notmuch.el | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index d8d3afe..ab58fcb 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -411,13 +411,13 @@ the region between points BEG and END.  As a special
> case, if (=
>  BEG END), FUNCTION will be applied to the result containing point
>  BEG."
>
> -  (lexical-let ((pos (notmuch-search-result-beginning beg))

> - (first t))
> +  (let ((pos (notmuch-search-result-beginning beg))

I'm pretty sure there's a reason Austin used lexical-let in the first
place, but maybe someone can convince me it isn't needed.

Since emacs 26 is not released yet, I guess you mean the master branch
of emacs? Since it currently doesn't compile, I can't really debug. Do
you have a precise revision that you have tested?

If you want to try to debug this you could try using git bisect (on
emacs) to figure out what commit broke things.

Another useful thing to know is whether emacs master can byte-compile
the minimal example attached. There will be warnings, but there should
not be any errors.

d


[-- Attachment #2: test.el --]
[-- Type: application/emacs-lisp, Size: 1008 bytes --]

[-- Attachment #3: Type: text/plain, Size: 108 bytes --]


PS: I couldn't actually apply that patch. Maybe try git-format-patch and
use an attachment if using gmail.