From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id A005D6DE0350 for ; Wed, 15 Nov 2017 04:59:50 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.001 X-Spam-Level: X-Spam-Status: No, score=-0.001 tagged_above=-999 required=5 tests=[AWL=0.010, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rg2jgZp3GDxT for ; Wed, 15 Nov 2017 04:59:50 -0800 (PST) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id E540C6DE02DD for ; Wed, 15 Nov 2017 04:59:49 -0800 (PST) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1eExIC-0005CZ-GW; Wed, 15 Nov 2017 07:59:48 -0500 Received: (nullmailer pid 30462 invoked by uid 1000); Wed, 15 Nov 2017 12:59:47 -0000 From: David Bremner To: Daniel Kahn Gillmor , Notmuch Mail Subject: Re: [PATCH 03/18] crypto: use stashed session-key properties for decryption, if available In-Reply-To: <87mv3px8wc.fsf@fifthhorseman.net> References: <20171025065203.24403-1-dkg@fifthhorseman.net> <20171025065203.24403-4-dkg@fifthhorseman.net> <87r2t19fov.fsf@tethera.net> <87mv3px8wc.fsf@fifthhorseman.net> Date: Wed, 15 Nov 2017 08:59:47 -0400 Message-ID: <874lpvae9o.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2017 12:59:50 -0000 Daniel Kahn Gillmor writes: > I also >> don't know how motivated gmime upstream is to fix bugs in 2.6; I could >> certainly understand if the answer was "not very". > > I believe the answer is "not very" -- but if there are serious bugs (i > don't think we've talked about any of this stuff as bugs in gmime) then > we should probably try to raise them with him. I think Jani tried a bit to narrow it down, but didn't succeed. Part of the problem (which I suspect is endemic to crypto issues) is that we don't have public test cases. > >> There is, by the way, a function notmuch_built_with that can be used to >> introspect the library as to what optional features it is built >> with. It's used in notmuch_config to report back to the user about the >> presence of optional features. > > Is there any naming convention for these features? do you want me to > add a "session-key" label with a future revision of this branch? or are > you asking for something else? It could be a followup, but yeah, if there is some feature that is sometimes compiled in, and sometimes not, then it should be listed along with the others. For whatever reason, the existing convention is 'session_key' This discussion does make me think there should probably be a test in configure that sets a corresponding feature macro HAVE_GMIME_SESSION_KEYS, in a manner similar to HAVE_XAPIAN_COMPACT (possibly just centralizing the version comparison currently used). d