unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] test: session keys are known broken without session key support
@ 2017-12-05 18:40 Daniel Kahn Gillmor
  2017-12-05 18:42 ` Daniel Kahn Gillmor
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Kahn Gillmor @ 2017-12-05 18:40 UTC (permalink / raw)
  To: Notmuch Mail

If the version of GMime we're building against doesn't support session
key extraction or re-use, mark the tests that rely on session key
capabilities as known-broken.

This should resolve test suite failures on ubuntu trusty and debian
jessie and earlier, which have GMime 2.6.20 -- session key support was
introduced in GMime 2.6.21.
---
 test/T357-index-decryption.sh | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/test/T357-index-decryption.sh b/test/T357-index-decryption.sh
index 11ea2074..3efaa61f 100755
--- a/test/T357-index-decryption.sh
+++ b/test/T357-index-decryption.sh
@@ -183,6 +183,9 @@ EOF
 notmuch reindex --try-decrypt id:simple-encrypted@crypto.notmuchmail.org
 output=$(notmuch search sekrit)
 expected='thread:0000000000000001   2016-12-22 [1/1] Daniel Kahn Gillmor; encrypted message (encrypted inbox unread)'
+if [ $NOTMUCH_HAVE_GMIME_SESSION_KEYS -eq 0 ]; then
+    test_subtest_known_broken
+fi
 test_expect_equal \
     "$output" \
     "$expected"
-- 
2.15.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] test: session keys are known broken without session key support
  2017-12-05 18:40 [PATCH] test: session keys are known broken without session key support Daniel Kahn Gillmor
@ 2017-12-05 18:42 ` Daniel Kahn Gillmor
  2017-12-07 13:24   ` David Bremner
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Kahn Gillmor @ 2017-12-05 18:42 UTC (permalink / raw)
  To: Notmuch Mail

On Tue 2017-12-05 13:40:27 -0500, Daniel Kahn Gillmor wrote:
> If the version of GMime we're building against doesn't support session
> key extraction or re-use, mark the tests that rely on session key
> capabilities as known-broken.
>
> This should resolve test suite failures on ubuntu trusty and debian
> jessie and earlier, which have GMime 2.6.20 -- session key support was
> introduced in GMime 2.6.21.

This should fix the current travis build failure.  If it's accepted,
i'll use the same technique to mark other tests in my session-keys
series as dependent upon session-key capability.

       --dkg

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] test: session keys are known broken without session key support
  2017-12-05 18:42 ` Daniel Kahn Gillmor
@ 2017-12-07 13:24   ` David Bremner
  0 siblings, 0 replies; 3+ messages in thread
From: David Bremner @ 2017-12-07 13:24 UTC (permalink / raw)
  To: Daniel Kahn Gillmor, Notmuch Mail

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> On Tue 2017-12-05 13:40:27 -0500, Daniel Kahn Gillmor wrote:
>> If the version of GMime we're building against doesn't support session
>> key extraction or re-use, mark the tests that rely on session key
>> capabilities as known-broken.
>>
>> This should resolve test suite failures on ubuntu trusty and debian
>> jessie and earlier, which have GMime 2.6.20 -- session key support was
>> introduced in GMime 2.6.21.
>
> This should fix the current travis build failure.  If it's accepted,
> i'll use the same technique to mark other tests in my session-keys
> series as dependent upon session-key capability.

pushed,

d

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-12-07 13:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-05 18:40 [PATCH] test: session keys are known broken without session key support Daniel Kahn Gillmor
2017-12-05 18:42 ` Daniel Kahn Gillmor
2017-12-07 13:24   ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).