From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 3332E6DE16C7 for ; Tue, 12 Jun 2018 14:36:53 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.013 X-Spam-Level: X-Spam-Status: No, score=-0.013 tagged_above=-999 required=5 tests=[AWL=-0.023, RCVD_IN_DNSWL_NONE=-0.0001, T_SPF_PERMERROR=0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qLTkdCuf2uSt for ; Tue, 12 Jun 2018 14:36:52 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTPS id 1501B6DE16D4 for ; Tue, 12 Jun 2018 14:36:52 -0700 (PDT) Received: from fifthhorseman.net (unknown [38.109.115.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id B8264F99A; Tue, 12 Jun 2018 17:36:47 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 4E9A120323; Tue, 12 Jun 2018 17:25:01 -0400 (EDT) From: Daniel Kahn Gillmor To: Thomas Schneider , Tomi Ollila , Notmuch Mail Subject: Re: [PATCH] devel: make printmimestructure py3 compatible In-Reply-To: <87bmcg5cpr.fsf@fifthhorseman.net> References: <20180611232244.27207-1-dkg@fifthhorseman.net> <87bmcg5cpr.fsf@fifthhorseman.net> Date: Tue, 12 Jun 2018 17:25:01 -0400 Message-ID: <874li766ky.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jun 2018 21:36:53 -0000 On Tue 2018-06-12 09:57:52 -0400, Daniel Kahn Gillmor wrote: > On Tue 2018-06-12 12:47:58 +0200, Thomas Schneider wrote: >> Tomi Ollila writes: >> >>> On Mon, Jun 11 2018, Daniel Kahn Gillmor wrote: >>> >>>> Make printmimestructure work in python3 as well as python2. >>>> >>>> PEP 394 suggests that python scripts that work with both python2 and >>>> python3 should have a #!/usr/bin/python command line, so do that too. >>> >>> I did not see PEP 394 suggesting to change >>> >>> -#!/usr/bin/env python >>> +#!/usr/bin/python >>> >>> just that 'python' should be able to run both python2 and python3 code. >>> >>> after the above change the code will not run on (those stupid) systems >>> that install python to e.g. /usr/local/bin/. >> >> For example all BSD systems, where the package manager installs to >> /usr/local (and I do not think this is stupid). >> >>> While I am not against this change, the commit message is misleading. >> >> For the above reason, I am against changing the shebang at all. > > ok, but devel/nmbug/notmuch-report uses #!/usr/bin/python, and i was > leaning toward making them consistent. if we care about using the > /usr/bin/env trick, we should use it consistently. > > i'm fine either way, my main goal with this series was to make > printmimestructure compatible with both py2 and py3, and i have no > interest in fighting about shebang lines. the thread starting at id:20180612212110.32533-1-dkg@fifthhorseman.net has a revised series that normalizes shebang lines on #!/usr/bin/env python while still incorporating the fixes from myself and jamie. --dkg