unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: Thomas Schneider <qsx@chaotikum.eu>,
	Tomi Ollila <tomi.ollila@iki.fi>,
	Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] devel: make printmimestructure py3 compatible
Date: Tue, 12 Jun 2018 17:25:01 -0400	[thread overview]
Message-ID: <874li766ky.fsf@fifthhorseman.net> (raw)
In-Reply-To: <87bmcg5cpr.fsf@fifthhorseman.net>

On Tue 2018-06-12 09:57:52 -0400, Daniel Kahn Gillmor wrote:
> On Tue 2018-06-12 12:47:58 +0200, Thomas Schneider wrote:
>> Tomi Ollila <tomi.ollila@iki.fi> writes:
>>
>>> On Mon, Jun 11 2018, Daniel Kahn Gillmor wrote:
>>>
>>>> Make printmimestructure work in python3 as well as python2.
>>>>
>>>> PEP 394 suggests that python scripts that work with both python2 and
>>>> python3 should have a #!/usr/bin/python command line, so do that too.
>>>
>>> I did not see PEP 394 suggesting to change 
>>>
>>> -#!/usr/bin/env python
>>> +#!/usr/bin/python
>>>
>>> just that 'python' should be able to run both python2 and python3 code.
>>>
>>> after the above change the code will not run on (those stupid) systems
>>> that install python to e.g. /usr/local/bin/.
>>
>> For example all BSD systems, where the package manager installs to
>> /usr/local (and I do not think this is stupid).
>>
>>> While I am not against this change, the commit message is misleading.
>>
>> For the above reason, I am against changing the shebang at all.
>
> ok, but devel/nmbug/notmuch-report uses #!/usr/bin/python, and i was
> leaning toward making them consistent.  if we care about using the
> /usr/bin/env trick, we should use it consistently.
>
> i'm fine either way, my main goal with this series was to make
> printmimestructure compatible with both py2 and py3, and i have no
> interest in fighting about shebang lines.

the thread starting at id:20180612212110.32533-1-dkg@fifthhorseman.net
has a revised series that normalizes shebang lines on

    #!/usr/bin/env python

while still incorporating the fixes from myself and jamie.

      --dkg

      reply	other threads:[~2018-06-12 21:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-11 23:22 [PATCH] devel: make printmimestructure py3 compatible Daniel Kahn Gillmor
2018-06-12  2:00 ` [PATCH] minor cleanup to printmimestructure Jameson Graef Rollins
2018-06-12  8:35 ` [PATCH] devel: make printmimestructure py3 compatible Tomi Ollila
2018-06-12  8:53   ` Reto Brunner
2018-06-12 10:47   ` Thomas Schneider
2018-06-12 13:57     ` Daniel Kahn Gillmor
2018-06-12 21:25       ` Daniel Kahn Gillmor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874li766ky.fsf@fifthhorseman.net \
    --to=dkg@fifthhorseman.net \
    --cc=notmuch@notmuchmail.org \
    --cc=qsx@chaotikum.eu \
    --cc=tomi.ollila@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).