From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id E32146DE10D1
 for <notmuch@notmuchmail.org>; Thu, 18 Apr 2019 19:22:47 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: -0.026
X-Spam-Level: 
X-Spam-Status: No, score=-0.026 tagged_above=-999 required=5
 tests=[AWL=-0.025, SPF_PASS=-0.001] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 71i8Hl78rzwH for <notmuch@notmuchmail.org>;
 Thu, 18 Apr 2019 19:22:47 -0700 (PDT)
Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
 by arlo.cworth.org (Postfix) with ESMTPS id 17C266DE10CC
 for <notmuch@notmuchmail.org>; Thu, 18 Apr 2019 19:22:46 -0700 (PDT)
Received: from remotemail by fethera.tethera.net with local (Exim 4.89)
 (envelope-from <david@tethera.net>) id 1hHJAr-0004T2-MW
 for notmuch@notmuchmail.org; Thu, 18 Apr 2019 22:22:45 -0400
Received: (nullmailer pid 28418 invoked by uid 1000);
 Fri, 19 Apr 2019 02:22:44 -0000
From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] CLI/reindex: fix memory leak
In-Reply-To: <20190416014616.31623-2-david@tethera.net>
References: <20190416014616.31623-1-david@tethera.net>
 <20190416014616.31623-2-david@tethera.net>
Date: Thu, 18 Apr 2019 23:22:44 -0300
Message-ID: <874l6ug2dn.fsf@tethera.net>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Apr 2019 02:22:48 -0000

David Bremner <david@tethera.net> writes:

> Since message is owned by messages, it was held for the entire run of
> the program. This in turn means that the Xapian::Document objects are
> not freed, and thus one ends up with (effectively) a copy of one's
> entire mailstore in memory when running

Pushed this one to master. People may be wanting to do a complete
reindex to take advantage of body: searches.

d