From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CGpnAye95F//EgAA0tVLHw (envelope-from ) for ; Thu, 24 Dec 2020 16:09:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id XJfnOia95F/BBAAA1q6Kng (envelope-from ) for ; Thu, 24 Dec 2020 16:09:10 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 48CA09401BC for ; Thu, 24 Dec 2020 16:09:10 +0000 (UTC) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 5BBA629CB5; Thu, 24 Dec 2020 11:09:04 -0500 (EST) Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by mail.notmuchmail.org (Postfix) with ESMTPS id F3F0F28536 for ; Thu, 24 Dec 2020 11:09:01 -0500 (EST) Received: by mail-ed1-x534.google.com with SMTP id b73so2439157edf.13 for ; Thu, 24 Dec 2020 08:09:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:in-reply-to:references:date:message-id :mime-version; bh=pItO4RrZycVTIED7evrVhtZ7Vnwfw0Y3lxc6De8Rl1k=; b=jNwjSXFo3PVul0XgLFcStrD9FbyMFuYvttdksnGDHyLFESL8IHTclNH3hKsFDGTIJ+ 3Ai/i68Xw32C7mz9la7DUqp39Fd/BELCSm1nuKzX4qYPCfrl+myP1GzJV8prcrgMFrZ6 zQBrlpuJRBpIMrqs6w4WPpljUN5GBtPxcU829toPTOPG5ClLpopkmps9RVtWdGwyFHWU yn22mj5+bRQTgvGtNNzcchHOJo2NAO+G0B/d1btCYdF061dVCfArJsRoMaXB7j27f+Qu Uyt1hva1Yza3GgRdiXuchqeVAYVQ5yJMS5Q6Ih6hTH75nZ6U7q3faM/p/5ev4JcIeHhC zwDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:in-reply-to:references :date:message-id:mime-version; bh=pItO4RrZycVTIED7evrVhtZ7Vnwfw0Y3lxc6De8Rl1k=; b=iDQjtqQMSp2IS3gm94TPPyQGMJX6aXzHCevjv5zeJElg8VmXmatE6D+jBiTJkda1St ggRdq4ywDccb1Jxfe9XTqhjM6NF2f3mR4gD+9r85YM1sGypM+TeYYYRBeOTzYuB+PMG4 zVrWL39sMje5Wh9B1+sTAY1V8A6Y3tYiNfIpjDAqwBmjEWIRzo0Em/cjYj5/VaQ/OxwJ eSfH4a5SX+OCFgBEKp98DznRx9Oe4e0wqZGuMCPXE0drDM5l7Va1iNFJxzzVpBfHpvnb fAgVSEqjtwx3/HsAZvWK80vMuWGaxsRCmEKo9LZCoq0blhrdoMOhaQe+HZUbnHzSYXB7 F1YQ== X-Gm-Message-State: AOAM533YjgA5TozzE8YE7w2e3c2KP4n9tcMwuPTyQTfO3THSxH8FhCgM SHGSzQQtMWqkvnurgbfd7AUtksDb6GQ= X-Google-Smtp-Source: ABdhPJxqB7jSBueFdL07IIUc5F4VDeg8h0wxWvVNa0A1S+tNgM3+92TtAgCcNnLwrnsprJgkTbc4Fg== X-Received: by 2002:aa7:df0d:: with SMTP id c13mr29672317edy.387.1608826133992; Thu, 24 Dec 2020 08:08:53 -0800 (PST) Received: from powell.devork.be (2a02-8388-8480-1180-4c18-fc69-8d8c-22b5.cable.dynamic.v6.surfer.at. [2a02:8388:8480:1180:4c18:fc69:8d8c:22b5]) by smtp.gmail.com with ESMTPSA id bn21sm13088680ejb.47.2020.12.24.08.08.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Dec 2020 08:08:53 -0800 (PST) Sender: Floris Bruynooghe Received: (nullmailer pid 519114 invoked by uid 1000); Thu, 24 Dec 2020 16:08:52 -0000 From: Floris Bruynooghe To: Johannes Larsen , notmuch@notmuchmail.org Subject: Re: python notmuch2 bindings exclude_tags not added correctly to query In-Reply-To: <160868726210.3559542.13236319044064062818@hue.johslarsen.net> References: <160868726210.3559542.13236319044064062818@hue.johslarsen.net> Date: Thu, 24 Dec 2020 17:08:52 +0100 Message-ID: <874kkbb2zv.fsf@powell.devork.be> MIME-Version: 1.0 Message-ID-Hash: GWVGPEAI3YBSXKOSUKIS4JYKRCDJ67HP X-Message-ID-Hash: GWVGPEAI3YBSXKOSUKIS4JYKRCDJ67HP X-MailFrom: floris.bruynooghe@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 0.60 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=gmail.com header.s=20161025 header.b=jNwjSXFo; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 48CA09401BC X-Spam-Score: 0.60 X-Migadu-Scanner: scn1.migadu.com X-TUID: FhWNiMdYlINV Hi Johannes, On Wed 23 Dec 2020 at 02:34 +0100, Johannes Larsen wrote: > A typo in Database._create_query loses the exclude_tag names during the > string to utf-8 conversion. > > > The problem is fixed by this patch applied to current master (ced341e8): > > diff --git i/bindings/python-cffi/notmuch2/_database.py w/bindings/python-cffi/notmuch2/_database.py > index 5ab0f20a..868f4408 100644 > --- i/bindings/python-cffi/notmuch2/_database.py > +++ w/bindings/python-cffi/notmuch2/_database.py > @@ -581 +581 @@ class Database(base.NotmuchObject): > - tag = str.encode('utf-8') > + tag = tag.encode('utf-8') Oops yes, someone else found this a while ago and I started working on a patch but that ended up in some yak shaving when the tests I wrote for it ended up accidentally unearthing other unrelated bugs and then I lost track of this... Apologies. Anyway, this fix LGTM even if I do prefer fixes to come with tests :) But that shouldn't stop a fix from being merged I guess. Cheers Floris