From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id OEH3IGvAm2A0VwEAgWs5BA (envelope-from ) for ; Wed, 12 May 2021 13:47:55 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id INSPHGvAm2C8eQAAB5/wlQ (envelope-from ) for ; Wed, 12 May 2021 11:47:55 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A0EC310922 for ; Wed, 12 May 2021 13:47:54 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id EBE7F2717B; Wed, 12 May 2021 07:47:50 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id C782C20017 for ; Wed, 12 May 2021 07:47:47 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 49B5660018; Wed, 12 May 2021 07:47:46 -0400 (EDT) Received: (nullmailer pid 1114298 invoked by uid 1000); Wed, 12 May 2021 11:47:44 -0000 From: David Bremner To: Michael J Gruber , notmuch@notmuchmail.org Subject: Re: [PATCH] test: change database from within pre-new hook In-Reply-To: <162080419530.6226.1085165083385413134.git@grubix.eu> References: <162076424929.3234.3999254277296434834.git@grubix.eu> <87fsyshpc6.fsf@tethera.net> <162080419530.6226.1085165083385413134.git@grubix.eu> Date: Wed, 12 May 2021 08:47:44 -0300 Message-ID: <874kf8gom7.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: EDX72IV6II6UVFRIFR2NJ5HEJZUL2O6O X-Message-ID-Hash: EDX72IV6II6UVFRIFR2NJ5HEJZUL2O6O X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620820074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Rx1l0wOoVocjwWgB79M6vwc1eUNCrPwdMDysYQ46OOc=; b=lE9r4fzSbngdWyrsG8b2Ki/Pos08TtG+xJONnvph9CJA6bz4laMFi3Ofq3wP3zy+rhwvxt y1Nv4KJdX30DLHwiMHXhpofdIAs2k1GCEri6eTheRfxm7+K5D9m/1Jh6751cjAhoFHRE++ JtDFUM3y5yZ9MtkwtPY81H/serfLj9wMk/IGU8CPlBX5ccGeXdoxoCCfFMkblYDQn2FVhZ yJXUOpXe3QRTUESouh2Jp7J1IRBxDORoefmS62p9vLvWVuDxTD/5rEPXLdK0bPqewWnUR0 caI1mJPJLUlkgdEKMOMNDx6rSpVap9QHYROfYmum9PZ9m5epRYdao+/chaoT1w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620820074; a=rsa-sha256; cv=none; b=RmlKEl06VN7BwLXx91dp88Hy7bjFEdnw4dFsQdfPYRQdtaZRo05FChU4P2Qv2rcUqpYBAM ZJzF0fbgk4b24CZNOUXO8S2UwAuMTGyDqx8dFjEcpisFtnbouNFfgVEZEhgbOkr6qvusjp Y+s80JuPqdzCugLMEJkh32VJg04L3ReSz1dT3Ox+h+iJsqQbrbF1QjVPk6DkgA0LMsu0eD a9/NeYExO9UCHJbwlj8nrqU3W+cgQb88nMClHofjCYNhdfugP6CiQXRSJNtN3flmvzUho0 FympW92B5lctbm419hHTh5W+X3eHYXkdytEjiEJ+T5bWWlw1rDMbtI7BSNH12w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.03 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: A0EC310922 X-Spam-Score: -2.03 X-Migadu-Scanner: scn0.migadu.com X-TUID: XC/XA2Fy2zJU Michael J Gruber writes: > > I was wondering if it's worthwhile to test also: > - that the change from pre hook is persistent (test for that msg) I added this to the version of test that I just pushed. > - test the same for post (even though the db is closed before) > It wouldn't hurt, but I think it can wait until we get this point release out the door.