From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uNMGMZ1QomBKOgAAgWs5BA (envelope-from ) for ; Mon, 17 May 2021 13:16:45 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id iAWbLJ1QomBGPgAAbx9fmQ (envelope-from ) for ; Mon, 17 May 2021 11:16:45 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7501D1D3D4 for ; Mon, 17 May 2021 13:16:45 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 16C902A9FA; Mon, 17 May 2021 07:16:42 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id B47CD2905B for ; Mon, 17 May 2021 07:16:40 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 9280C60018; Mon, 17 May 2021 07:16:40 -0400 (EDT) Received: (nullmailer pid 3973817 invoked by uid 1000); Mon, 17 May 2021 11:16:39 -0000 From: David Bremner To: Felipe Contreras Subject: Re: [PATCH v2 2/6] test: more style fixes In-Reply-To: References: <20210515204744.965206-1-felipe.contreras@gmail.com> <20210515204744.965206-3-felipe.contreras@gmail.com> <87y2cezxrv.fsf@tethera.net> Date: Mon, 17 May 2021 08:16:39 -0300 Message-ID: <874kf1zk2w.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: VO6AC7SL5HOK2V7Q3TUK65RLVYMKERQX X-Message-ID-Hash: VO6AC7SL5HOK2V7Q3TUK65RLVYMKERQX X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: "notmuch@notmuchmail.org" X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621250205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=bceivzEQQu4u6w5fBFg7wpcw6mSjWGBe3Ha9aVn8q00=; b=qRQZVCifca6v4G1IlpaLUyJjPqcRq+oM7tG/2R8LEf0DgrhbFn58nuA9nb4/AxVVZ6oQbJ XzRJPAJW0Hn/SRPuo0lj2Ya87U9payuEW1eH8H4Tw7Hjm+0FOxkqa6ISIwrZnoEM8pfT3Q 7zgpdq4a9zwVp2vVRqZJ/UV7JtnCw6a3adE5iTfpsIlIOdTi8sp+/vfaU02bXxjc/LIRpW N+oHElE8H40+MgBdrHxPs6p+VH0tIuUs9s1naNlhgQbe+BmVYlQ6udptJ9iqhIoo4zlkQe vd4tVuD8G16goB8EYXfJGyxKTBHnAbCW6Bi9NHOKa/fSNRxLcs0gdOKTtrYXqA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621250205; a=rsa-sha256; cv=none; b=svfKekJAggAMw1JxVhsF4ijrKMq86u33/P/GTEg0tNBSttdYI6Eu6aZMNjnqVFSuTZ26JI 5IUqi74nu4sM9Qd4aektKmt0AwCqQY3WSLNzbo87oBFnOSC5vT//M8uDH10nyuXf42Ac1D m+U38kduRs3Zr8GYHnBl2G3+OJxsKes1SHADfJ9S/MAczipBDFWxF/MDERt0IBo7LKns84 EawP0KClHZhs9JEmT6DZlJlvddL+1XMgtgRofsQJ4gC6dFfbkvdTO0i83AEOK6QFWuxBvG wlhxcSjY78C8AuE6OaS2DYVllrHR8rDv4wbCbURGtOPREFs4WQBuZ4V/mqejrw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.07 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 7501D1D3D4 X-Spam-Score: -2.07 X-Migadu-Scanner: scn0.migadu.com X-TUID: GVyU1im/LCsB Felipe Contreras writes: > The testing framework for example seems to come from the git project, > which has a C style of: > > void function(void) > { > } > > But a shell style of: > > function () { > } I looked at the existing code, and it does seem to mostly use the latter style. So I guess this change is less disruptive than flipping everything the other way. > I may have been spoiled by them, but I like both styles. Additionally > the testing framework was split into the sharness project [1], which > obviously has the same shell style. BTW, at some point you might want > to use sharness, instead of maintaining your own testing framework. That would depend how much work is involved in porting 17k+ lines of tests. > So my vote is no: we should not strive with consistency with the C > code. The original git shell style is fine, and if we adopt it, we can > refer to it in test/README instead of defining our own. Here again I'd want to see how much change to the test suite is necessary to conform. I noticed a few things (like the location of "then") where we don't currently follow the git shell style very closely. d