From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gDfmB/2o2GAhDgEAgWs5BA (envelope-from ) for ; Sun, 27 Jun 2021 18:36:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id QBeWA/2o2GBPDAAAB5/wlQ (envelope-from ) for ; Sun, 27 Jun 2021 16:36:13 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 554541D219 for ; Sun, 27 Jun 2021 18:36:12 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 490F5290ED; Sun, 27 Jun 2021 12:36:06 -0400 (EDT) Received: from che.mayfirst.org (che.mayfirst.org [IPv6:2001:470:1:116::7]) by mail.notmuchmail.org (Postfix) with ESMTPS id 6F774290D9 for ; Sun, 27 Jun 2021 12:36:02 -0400 (EDT) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1624811761; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=UdxhzCQoI1UwmXZPG2/fR6O3JktOtmmIRPkPV9kZ/80=; b=ruUkJie7S8rhKbQJK+wnIl6A2NMoK9SqYvH4griM8FVMXS0d/n6fr626oYCEanwrZyEw6 rBnnqVFiapWEwchBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1624811761; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=UdxhzCQoI1UwmXZPG2/fR6O3JktOtmmIRPkPV9kZ/80=; b=UfXodAaW0zKaKEIeVlzU4rcwyojHKDFPDSa8redFJgAPfHkCuMSFVTlgNOjIVoulVGR0U THZFV3RJpm1YJ3KLvrpwQDksH7hnSGGhx0Q3tdEh0F1utYV2gxSLIT+mFoAdM++uiNVW82Y RFgSSo/vcSJfhg6wWxDvHKhVAYUSfJTBAtgcq5aawL/tzDGUF2Dv8PMeRVk1NVt1HtH1JZn voaTOFAxOpxHzEXeFpMdIMHjzcI112NpBNJ78SCzn2DxsQmkEUGG2oCdrSLl1fYTVsWTDZf XsZK7cgznaRY0pWb0v+DKkFXZC+fppYcQzfci5PRpwIgcaQkAMeF0ChmAyuQ== Received: from fifthhorseman.net (c-73-106-144-119.hsd1.ga.comcast.net [73.106.144.119]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id B7176F9A5; Sun, 27 Jun 2021 12:36:01 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 8C8FB203D8; Sun, 27 Jun 2021 11:13:06 -0400 (EDT) From: Daniel Kahn Gillmor To: David Bremner , Notmuch Mail Subject: Re: [PATCH] emacs: Prefer email address over User ID when showing valid signature In-Reply-To: <20210626164144.227608-1-david@tethera.net> References: <20210527014459.3082888-2-dkg@fifthhorseman.net> <20210626164144.227608-1-david@tethera.net> Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEX+i03xYJKwYBBAHaRw8BAQdACA4xvL/xI5dHedcnkfViyq84doe8zFRid9jW7CC9XBiI0QQf FgoAgwWCX+i03wWJBZ+mAAMLCQcJEOCS6zpcoQ26RxQAAAAAAB4AIHNhbHRAbm90YXRpb25zLnNl cXVvaWEtcGdwLm9yZ/tr8E9NA10HvcAVlSxnox6z62KXCInWjZaiBIlgX6O5AxUKCAKbAQIeARYh BMKfigwB81402BaqXOCS6zpcoQ26AADZHQD/Zx9nc3N2kj13AUsKMr/7zekBtgfSIGB3hRCU74Su G44A/34Yp6IAkndewLxb1WdRSokycnaCVyrk0nb4imeAYyoPtBc8ZGtnQGZpZnRoaG9yc2VtYW4u bmV0PojRBBMWCgCDBYJf6LTfBYkFn6YAAwsJBwkQ4JLrOlyhDbpHFAAAAAAAHgAgc2FsdEBub3Rh dGlvbnMuc2VxdW9pYS1wZ3Aub3JnL0Gwxvypz2tu1IPG+yu1zPjkiZwpscsitwrVvzN3bbADFQoI ApsBAh4BFiEEwp+KDAHzXjTYFqpc4JLrOlyhDboAAPkXAP0Z29z7jW+YzLzPTQML4EQLMbkHOfU4 +s+ki81Czt0WqgD/SJ8RyrqDCtEP8+E4ZSR01ysKqh+MUAsTaJlzZjehiQ24MwRf6LTfFgkrBgEE AdpHDwEBB0DkKHOW2kmqfAK461+acQ49gc2Z6VoXMChRqobGP0ubb4kBiAQYFgoBOgWCX+i03wWJ BZ+mAAkQ4JLrOlyhDbpHFAAAAAAAHgAgc2FsdEBub3RhdGlvbnMuc2VxdW9pYS1wZ3Aub3Jnfvo+ nHoxDwaLaJD8XZuXiaqBNZtIGXIypF1udBBRoc0CmwICHgG+oAQZFgoAbwWCX+i03wkQPp1xc3He VlxHFAAAAAAAHgAgc2FsdEBub3RhdGlvbnMuc2VxdW9pYS1wZ3Aub3JnaheiqE7Pfi3Atb3GGTw+ jFcBGOaobgzEJrhEuFpXREEWIQQttUkcnfDcj0MoY88+nXFzcd5WXAAAvrsBAIJ5sBg8Udocv25N stN/zWOiYpnjjvOjVMLH4fV3pWE1AP9T6hzHz7hRnAA8d01vqoxOlQ3O6cb/kFYAjqx3oMXSBhYh BMKfigwB81402BaqXOCS6zpcoQ26AADX7gD/b83VObe14xrNP8xcltRrBZF5OE1rQSPkMNy+eWpk eCwA/1hxiS8ZxL5/elNjXiWuHXEvUGnRoVj745Vl48sZPVYMuDgEX+i03xIKKwYBBAGXVQEFAQEH QIGex1WZbH6xhUBve5mblScGYU+Y8QJOomXH+rr5tMsMAwEICYjJBBgWCgB7BYJf6LTfBYkFn6YA CRDgkus6XKENukcUAAAAAAAeACBzYWx0QG5vdGF0aW9ucy5zZXF1b2lhLXBncC5vcmcEAx9vTD3b J0SXkhvcRcCr6uIDJwic3KFKxkH1m4QW0QKbDAIeARYhBMKfigwB81402BaqXOCS6zpcoQ26AAAX mwD8CWmukxwskU82RZLMk5fm1wCgMB5z8dA50KLw3rgsCykBAKg1w/Y7XpBS3SlXEegIg1K1e6dR fRxL7Z37WZXoH8AH Date: Sun, 27 Jun 2021 11:13:04 -0400 Message-ID: <874kdjuyrj.fsf@fifthhorseman.net> MIME-Version: 1.0 Message-ID-Hash: DNGZG5DA4C6JI6BSSOPSQPY7SNRXBCHT X-Message-ID-Hash: DNGZG5DA4C6JI6BSSOPSQPY7SNRXBCHT X-MailFrom: dkg@fifthhorseman.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: multipart/mixed; boundary="===============9018747175297712193==" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624811772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature:autocrypt:autocrypt; bh=mcA04ifAlrdzKAxylvSd2LkzQ4yo/Jz4/P1BUXAe0rA=; b=sozBuluFHg9LuJ1p6JWgFFvIyxwq+YXc+D4Bo1LNfcUp10VRNCZX7h77dB9dwiRRIIG4+r tIGpBhhGFna1FpP0etd8W4/kEOhAV2XGuQIODTKfp4KjaHvKdn0zJDYate4pdU3YyXLwwQ 7QkrdoQxLxew0DK0wYBZtenr+dW38izycJaT4pwbaAIy54aRVyyYTLsiTd2PzEVQYtd3nT QumxyQSna7pr5XnYZV3j84rc6rkSBS9b086LdYTSLEWg8Vj2yKcoo9LdUbvUYEY4yZKWRx b0vPNrJcEZxfs0ECBjdmlgBnS/xN7B8tgbpNAsuMpWYxGkDHeTvvl2vxgnjMMg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624811772; a=rsa-sha256; cv=none; b=XjQK940vldVrsUchJb6lAqduOMoqvzK0e1Ol4Lvp31mDsbqOkpSv6zfVa0MZYtOilTHTL4 EIdGUrYHJXa9TdmE6UNbjKfFmVdcP9bBHU0qkoG+iuSg/XKRwRB+ho5o0SkSRWXICWERW5 gtMKqyVuwAKWJLauxn0QYUOWlVWBdcISPzB73FWvNb63VSta0ThbUrvE8S4KpcM7De2lIc 4d3yYT3aD+v7WRxJyY+ksGArutInxwQcQq+WfAlzhn0UKTWWIMCopK6j+i1kcCrHy13u/9 35gEq7WINQ/XDO9ID7qScBXtn/cz7RWA8QbMnCr4n7TUrx48CPQrL0Hue4V94Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=fifthhorseman.net header.s=2019 header.b=ruUkJie7; dkim=fail ("body hash did not verify") header.d=fifthhorseman.net header.s=2019rsa header.b=UfXodAaW; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fifthhorseman.net (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -3.02 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=fifthhorseman.net header.s=2019 header.b=ruUkJie7; dkim=fail ("body hash did not verify") header.d=fifthhorseman.net header.s=2019rsa header.b=UfXodAaW; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fifthhorseman.net (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 554541D219 X-Spam-Score: -3.02 X-Migadu-Scanner: scn1.migadu.com X-TUID: uBK4MTBQdAaY --===============9018747175297712193== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sat 2021-06-26 13:41:44 -0300, David Bremner wrote: > From: Daniel Kahn Gillmor > > Most concrete verification steps are likely only taken on the e-mail > address in the first place, and e-mail addresses render more > intelligibly than arbitrary User IDs in the first place. > > Signed-off-by: Daniel Kahn Gillmor > Amended-by: db, apply dme restructuring suggestions. > --- > emacs/notmuch-crypto.el | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el > index db7cb75d..5edfe94c 100644 > --- a/emacs/notmuch-crypto.el > +++ b/emacs/notmuch-crypto.el > @@ -119,14 +119,14 @@ mode." > (cond > ((string=3D status "good") > (let ((fingerprint (concat "0x" (plist-get sigstatus :fingerprint)= )) > - (userid (plist-get sigstatus :userid))) > - ;; If userid is present it has full or greater validity. > - (if userid > - (progn > - (setq label (concat "Good signature by: " userid)) > - (setq face 'notmuch-crypto-signature-good)) > - (setq label (concat "Good signature by key: " fingerprint)) > - (setq face 'notmuch-crypto-signature-good-key)) > + (email-or-userid (or (plist-get sigstatus :email) > + (plist-get sigstatus :userid)))) > + ;; If email or userid are present, they have full or greater validity. > + (setq label (concat "Good signature by key: " fingerprint)) > + (setq face 'notmuch-crypto-signature-good-key) > + (when email-or-userid > + (setq label (concat "Good signature by: " email-or-user-id)) > + (setq face 'notmuch-crypto-signature-good)) > (setq button-action 'notmuch-crypto-sigstatus-good-callback) > (setq help-msg (concat "Click to list key ID 0x" fingerprint ".")))) > ((string=3D status "error") > --=20 > 2.30.2 LGTM. Thanks, Bremner! --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQQttUkcnfDcj0MoY88+nXFzcd5WXAUCYNiVggAKCRA+nXFzcd5W XNhRAP9N+AvyRnIugOxS8UWaGsEp7aOMrTDXhZrwgjxpHw/TIgEAr2w2xA1QROTJ V1KA/jS0xi0+IC6qwfgETjP8ozrhPw8= =rPzl -----END PGP SIGNATURE----- --=-=-=-- --===============9018747175297712193== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============9018747175297712193==--