From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MIYoJtKfz2HPgQEAgWs5BA (envelope-from ) for ; Sat, 01 Jan 2022 01:26:58 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id W7HOHtKfz2FaZAAAG6o9tA (envelope-from ) for ; Sat, 01 Jan 2022 01:26:58 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 42D0FB111 for ; Sat, 1 Jan 2022 01:26:58 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 9968C5F707; Sat, 1 Jan 2022 00:26:53 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 01C075F6BA for ; Sat, 1 Jan 2022 00:26:49 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 43EEF5FC42; Fri, 31 Dec 2021 19:26:49 -0500 (EST) Received: (nullmailer pid 3950652 invoked by uid 1000); Sat, 01 Jan 2022 00:26:48 -0000 From: David Bremner To: Mark Walters , Carl Worth , notmuch Subject: Re: [RFC PATCH] Re: excessive thread fusing In-Reply-To: <8738h7kv2q.fsf@qmul.ac.uk> References: <87ioq5mrbz.fsf@maritornes.cs.unb.ca> <87fvl8mpzj.fsf@qmul.ac.uk> <87oazwjq1e.fsf@yoom.home.cworth.org> <877g6kmcmh.fsf@qmul.ac.uk> <8738h7kv2q.fsf@qmul.ac.uk> Date: Fri, 31 Dec 2021 20:26:48 -0400 Message-ID: <874k6owbav.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: ZMRMXUCEDVHOE545EG5DFYBTDLK4RMDS X-Message-ID-Hash: ZMRMXUCEDVHOE545EG5DFYBTDLK4RMDS X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640996818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=u/22EHct2d+bmot5psUiT5XNpCxCAAWYU1A1snJt0qU=; b=l73jGvTbSgsnEuD+0iX7c4whSszvfKizeUDAc1ehFsJlFuE99Im2p0AUUq35JDVEkcrxEs 7ENn3ynTkiTiGRQpvqvsp+wRQpmorAWKdaU6+6t3NOBrvtRlodn6r4axGhU7DwFrxcqGNG iWCbqnrP2mgPByxxqSFx+T+dFumhRAvIYHS6GzVt+MoUHAfN/Ln+BsfJPad8cIJP7ou2X5 iwIS90L0SJueay9trryf9Omwh3KNKDXjpHB647S3I9sVnUC8H6IwRWz1DKcFWbzSC5g/Mv LSRva7+hkrQK3W67N0NtAnjSHBI36hx30+StaSDK6Vkz/N1bwFayoOj2xzwXHg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640996818; a=rsa-sha256; cv=none; b=sUy/q/9EfYoFz0nwxvZ50wOKxz6EtC38iwg8B3uY0WSwbmKSnqQb4JqgtcZZmdmne/pXB4 ZXSqv+ISRoJmm6qW02inlXuovFb9hWM/1Kjhct5CrJFJlIaBA6SAaK3m/N81RNytlGaNlQ 3WzFYX+VGimDlM87aZYJSfa9lezuiqfNwwTjWhaoHJZyVvR4k5dDS/uTVTjVUlkzQM35Eb 80BlWDo7H6PVaAbUp9pB7lTSs6v3nQuCFcIOmDCuRVBEaJRoo8IANxsxKmrzZDjwF0esL1 yBTneJN6i866QjRz4ThP+4hAD11IqNmCbAzFSvA1LwodSalwkG08CXzHAIanlQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.21 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 42D0FB111 X-Spam-Score: -2.21 X-Migadu-Scanner: scn1.migadu.com X-TUID: q2D+w0TqI2SK Mark Walters writes: >>> I haven't tracked through all the logic of the existing algorithm for >>> this case. But I don't like hearing that notmuch constructs different >>> threads for the same messages presented in different orders. This sounds >>> like a bug separate from what we've discussed above. > > I think I have now found this bug and it is separate from the malformed > In-Reply-To problems. > > The problem is that when we merge threads we update all the thread-ids > of documents in the loser thread. But we don't (if I understand the code > correctly) update dangling "metadata" references to threads which don't > (yet) have any documents. This bug seems fixed by the introduction of ghost messages discussed later in the thread, so marking it fixed. The question of malformed In-Reply-To headers (and whether there is a bug handling those) is discussed in the thread id:20211226161716.2079457-1-david@tethera.net.