From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>,
Carl Worth <cworth@cworth.org>, notmuch <notmuch@notmuchmail.org>
Subject: Re: [RFC PATCH] Re: excessive thread fusing
Date: Fri, 31 Dec 2021 20:26:48 -0400 [thread overview]
Message-ID: <874k6owbav.fsf@tethera.net> (raw)
In-Reply-To: <8738h7kv2q.fsf@qmul.ac.uk>
Mark Walters <markwalters1009@gmail.com> writes:
>>> I haven't tracked through all the logic of the existing algorithm for
>>> this case. But I don't like hearing that notmuch constructs different
>>> threads for the same messages presented in different orders. This sounds
>>> like a bug separate from what we've discussed above.
>
> I think I have now found this bug and it is separate from the malformed
> In-Reply-To problems.
>
> The problem is that when we merge threads we update all the thread-ids
> of documents in the loser thread. But we don't (if I understand the code
> correctly) update dangling "metadata" references to threads which don't
> (yet) have any documents.
This bug seems fixed by the introduction of ghost messages discussed
later in the thread, so marking it fixed. The question of malformed
In-Reply-To headers (and whether there is a bug handling those) is
discussed in the thread id:20211226161716.2079457-1-david@tethera.net.
next prev parent reply other threads:[~2022-01-01 0:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-19 12:33 excessive thread fusing David Bremner
2014-04-19 17:52 ` Eric
2014-04-19 21:04 ` Andrei POPESCU
2014-04-20 16:48 ` Austin Clements
2014-04-20 17:46 ` Austin Clements
2014-04-20 7:14 ` [RFC PATCH] " Mark Walters
[not found] ` <87oazwjq1e.fsf@yoom.home.cworth.org>
2014-04-20 12:03 ` Mark Walters
2014-04-21 7:20 ` Mark Walters
2014-04-21 16:20 ` Austin Clements
2022-01-01 0:26 ` David Bremner [this message]
2014-04-20 12:59 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k6owbav.fsf@tethera.net \
--to=david@tethera.net \
--cc=cworth@cworth.org \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).